From f2ec820ae0bb0bfbdf85293faa22e6220a6116c7 Mon Sep 17 00:00:00 2001 From: Andrii Veremeienko Date: Wed, 27 Oct 2021 15:34:11 +0300 Subject: [PATCH] Bug 23479: Hold cancellation confirmation too generic MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Solution was to specify patron's name in format ()" and biblio's title in the hold cancellation message. e.g.: 'Are you sure you want to cancel hold of "Охрана окружающей среды в републике Беларусь" for "John Doe (12)"?' How to test: 1. Go to the item search; 2. Search for the book you want to place hold for; 3. Select existing patron to place hold for him; 4. Place hold; 5. Go to koha/reserve/request.pl; 6. Click on "Cancel hold" button for hold from the list (red X icon on the grid); 7. Observe that text displayed on cancellation modal window is very general and doesn't contains patron's name and biblio's title; 8. Apply patch; 9. Go through steps 1-6; 10. Observe that cancellation text contains patron's name and biblio's title; Signed-off-by: Barbara Johnson --- koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc | 7 ++++++- .../intranet-tmpl/prog/en/modules/reserve/request.tt | 8 +++++++- reserve/request.pl | 1 + 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc index 516b04f322..2bc30c7a54 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc @@ -190,7 +190,12 @@ [%- END -%] [%- END -%] - + Cancel diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index a6d269f71f..a516f798ba 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1041,7 +1041,7 @@