From 85a095fe7b030058a008a8497763543d48f5c99e Mon Sep 17 00:00:00 2001 From: Owen Date: Thu, 28 Oct 2021 14:46:00 +0000 Subject: [PATCH] Bug 29352: Runtime parameter labels should not be said to be optional This patch alters the form shown when using the "Insert runtime parameter" button in SQL reports. It makes the label field required and removes "optional" from the field hint. To test, apply the patch and go to Reports -> Create from SQL. - Click the "Insert runtime parameter" button and select "Authorized value." - Clear the "parameter label" field and click "Insert parameter." - The form should display an error asking you to fill in the label field. - Test that the category field is also required. - Close the modal and select a different runtime parameter. - Test again that the label field is required. - Test that the form submits correctly when the label field is populated. --- .../prog/en/modules/reports/guided_reports_start.tt | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt index e766923601..8b1ed4f447 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt @@ -1379,9 +1379,9 @@