From 383523fcaeb2255b0d2117dcc1e3a78a3a6648f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= Date: Thu, 29 Jul 2021 17:23:01 +0300 Subject: [PATCH] Bug 28782: Use query param list instead of splitting elements using '/' This removes the need to handle single and multiple cases separately, thus removing bunch if-else cases and simplifying our code. This coding style is also in line with our other .pl scripts. To test: 1) Make sure placing a hold still works from the following pages: /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXX /cgi-bin/koha/catalogue/search.pl?q=a /cgi-bin/koha/virtualshelves/shelves.pl?op=view&shelfnumber=XXXX /cgi-bin/koha/clubs/clubs.pl (create a new club and add a patron there and through the clubs.pl create a hold to a bib) Signed-off-by: Hayley Pelham Signed-off-by: Martin Renvoize --- .../prog/en/includes/clubs-table.inc | 8 +-- .../prog/en/modules/catalogue/results.tt | 2 - .../prog/en/modules/reserve/request.tt | 51 ++++++++----------- .../prog/en/modules/virtualshelves/shelves.tt | 8 ++- koha-tmpl/intranet-tmpl/prog/js/cart.js | 21 +++----- .../intranet-tmpl/prog/js/pages/results.js | 9 ++-- reserve/modrequest.pl | 5 +- reserve/placerequest.pl | 18 +++---- reserve/request.pl | 14 ++--- 9 files changed, 58 insertions(+), 78 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc index 233ccf3d04..ea90d84864 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/clubs-table.inc @@ -20,10 +20,12 @@ [% FOREACH c IN clubs %] [% IF destination == 'holds' %] + [% SET data_url = "/cgi-bin/koha/reserve/request.pl?club=" _ c.id %] + [% FOREACH biblionumber IN biblionumbers %] + [% SET data_url = data_url _ "&biblionumber=" _ biblionumber %] + [% END %] [% IF multi_hold %] - [% SET data_url = "/cgi-bin/koha/reserve/request.pl?club=" _ c.id _ "&multi_hold=1&biblionumbers=" _ biblionumbers %] - [% ELSE %] - [% SET data_url = "/cgi-bin/koha/reserve/request.pl?club=" _ c.id _ "&biblionumber=" _ biblionumber %] + [% SET data_url = data_url _ "&multi_hold=1" %] [% END %] [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt index 4115ddacf7..99acc34461 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt @@ -671,14 +671,12 @@
-
-
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index a6d269f71f..c8130b7c47 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -138,14 +138,12 @@ [% END %]
-
+
Enter patron card number or partial name:
- [% IF multi_hold %] - - [% ELSE %] - + [% FOREACH biblionumber IN biblionumbers %] + [% END %]
@@ -155,14 +153,12 @@
[% IF clubcount %]
-
+
Enter club ID or partial name:
- [% IF multi_hold %] - - [% ELSE %] - + [% FOREACH biblionumber IN biblionumbers %] + [% END %]
@@ -181,7 +177,6 @@
[% IF ( multi_hold ) %] - [% FOREACH biblioloo IN biblioloop %] @@ -189,7 +184,6 @@ [% END %] [% ELSE %] - [% END # /IF multi_hold %] @@ -424,8 +418,10 @@ + [% FOREACH biblionumber IN biblionumbers %] + + [% END %] [% IF ( multi_hold ) %] - @@ -434,7 +430,6 @@ [% END %] [% ELSE %] - [% END # /IF multi_hold %] @@ -880,7 +875,9 @@ [% IF ( reserveloop ) %] [% IF ( multi_hold ) %] - + [% FOREACH biblionumber IN biblionumbers %] + + [% END %] [% END %] [% IF enqueued %] @@ -1074,7 +1071,7 @@ [% INCLUDE 'select2.inc' %]