Bugzilla – Attachment 127412 Details for
Bug 29430
Table cell click doesn't activate buttons in patron search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29430: Table cell click doesn't activate buttons in patron search
Bug-29430-Table-cell-click-doesnt-activate-buttons.patch (text/plain), 1.98 KB, created by
Joonas Kylmälä
on 2021-11-06 16:27:26 UTC
(
hide
)
Description:
Bug 29430: Table cell click doesn't activate buttons in patron search
Filename:
MIME Type:
Creator:
Joonas Kylmälä
Created:
2021-11-06 16:27:26 UTC
Size:
1.98 KB
patch
obsolete
>From 56477ce8f26c615665a6d354400b0286d8a975dc Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 5 Nov 2021 18:19:40 +0000 >Subject: [PATCH] Bug 29430: Table cell click doesn't activate buttons in > patron search >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Bug 15812 included a change which allows a click on the patron >search results table cell to toggle the checkbox it contains. This patch >modifies that click event so that it fires the change() event which is >required for toggling the "Add to patron list" and "Merge patrons" >buttons. > >To reproduce this problem, perform a patron search in the staff client >which will return multiple results. > - In the first column containing checkboxes, click in the empty part of > the table cell. The checkbox should be checked. > - However, the "Add to patron list" button remains disabled. > - Clicking a table cell to check another checkbox should result in the > "Merge selected patrons" button being enabled, but it doesn't. > >To test, apply the patch and repeat the process above. The behavior of >the buttons should be the same whether you're clicking the checkbox >itself or the table cell it's in. > >Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> > >Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 4a4e50650a..82d3a5bbb4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -586,6 +586,7 @@ > var $checkbox = $(this).find("input[type=checkbox]"); > if (e.target.type != "checkbox") { > $checkbox.prop('checked', !$checkbox.prop("checked")); >+ $checkbox.change(); > } > }); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29430
:
127401
|
127407
| 127412