From 25b1e85d0b6816e2547e44e60e38cb1cc831b21d Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Thu, 4 Feb 2021 00:27:11 +0000 Subject: [PATCH] Bug 27613: Change pipe seperated online resource links to psuedo elements To test: 1. Have a record with many 856 links 2. Look at the links on both the results and detail pages. 3. Look at the '|' and notice it is outside any HTML element, making it hard to remove. 4. Apply the patch and regenerate the CSS 5. Look at both the pages again and notice that the '|' is now a psuedo element. 6. It should look identical to the way it did without the patch 7. Switch the system pref OPACURLOpenInNewWindow to 'do' and make sure the the links look and function right still. Signed-off-by: Owen Leonard --- .../opac-tmpl/bootstrap/css/src/opac.scss | 25 +++++ .../en/xslt/MARC21slim2OPACDetail.xsl | 102 +++++++++--------- .../en/xslt/MARC21slim2OPACResults.xsl | 14 ++- 3 files changed, 81 insertions(+), 60 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss index 2f48d69f60..c505ad8749 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss +++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss @@ -1148,6 +1148,31 @@ div { } } +.online_resources { + ul { + display: inline-block; + margin: 0 auto; + padding-left: 0; + } + + li { + display: inline-block; + white-space: nowrap; + + &::after { + content: " | "; + } + + &:last-child { + &::after { + content: ""; + } + } + + } + +} + #views { margin-bottom: .5em; padding: 0 2em .2em .2em; diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl index a7dd374ae5..be0f96cde1 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl @@ -994,60 +994,58 @@ Online resources: - - - - - - /cgi-bin/koha/tracklinks.pl?uri=&biblionumber= - - - /cgi-bin/koha/tracklinks.pl?uri=&biblionumber= - - - - - - - :// - - - ftp:// - - - http:// - - - - - - - - - _blank - + diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl index 40e73b4f22..1b220dbac9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl @@ -1153,10 +1153,11 @@ Online access: + -- 2.20.1