From eb5d200816a370391148899e1f2f77d927f7d444 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 12 Nov 2021 10:40:32 +0000 Subject: [PATCH] Bug 28962: (QA follow-up) Fix test for objects Content-Type: text/plain; charset=utf-8 Simpler to check the ref instead of isa. Fix the bug where object is first stringified and then tested for being a Koha::Item. Signed-off-by: Marcel de Rooy --- C4/Log.pm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/C4/Log.pm b/C4/Log.pm index 3f1255b25e..26fcad526c 100644 --- a/C4/Log.pm +++ b/C4/Log.pm @@ -77,12 +77,13 @@ sub logaction { $usernumber ||= 0; $interface //= C4::Context->interface; - if ( ref($infos) && ref($infos) !~ /HASH|ARRAY/ && $infos->isa('Koha::Object') ) { + my $ref_type = ref($infos); + if( $ref_type =~ /^Koha::/ ) { $infos = $infos->get_from_storage if $infos->in_storage; local $Data::Dumper::Sortkeys = 1; $infos = Dumper( $infos->unblessed ); - if ( $infos->isa('Koha::Item') && $modulename eq 'CATALOGUING' && $actionname eq 'MODIFY' ) { + if( $ref_type eq 'Koha::Item' && $modulename eq 'CATALOGUING' && $actionname eq 'MODIFY' ) { $infos = "item " . $infos; } } -- 2.20.1