From ae7c52f84087fad9fea9a31979bc3da5458b403f Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 12 Nov 2021 10:40:32 +0000 Subject: [PATCH] Bug 28692: (QA follow-up) Fix test for objects Content-Type: text/plain; charset=utf-8 Fix the bug where object is first stringified and then tested for being a Koha::Item. Note: simple test since even 2->isa('Some::Class') works fine. Signed-off-by: Marcel de Rooy --- C4/Log.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/Log.pm b/C4/Log.pm index 3f1255b25e..b1758c9604 100644 --- a/C4/Log.pm +++ b/C4/Log.pm @@ -77,13 +77,14 @@ sub logaction { $usernumber ||= 0; $interface //= C4::Context->interface; - if ( ref($infos) && ref($infos) !~ /HASH|ARRAY/ && $infos->isa('Koha::Object') ) { + if( $infos->isa('Koha::Object') ) { $infos = $infos->get_from_storage if $infos->in_storage; local $Data::Dumper::Sortkeys = 1; - $infos = Dumper( $infos->unblessed ); if ( $infos->isa('Koha::Item') && $modulename eq 'CATALOGUING' && $actionname eq 'MODIFY' ) { - $infos = "item " . $infos; + $infos = "item " . Dumper( $infos->unblessed ); + } else { + $infos = Dumper( $infos->unblessed ); } } -- 2.20.1