From 710d445e56206ae1cc0c4767f0805f489f3b73cf Mon Sep 17 00:00:00 2001 From: Paul Poulain Date: Thu, 11 Oct 2012 14:54:48 +0200 Subject: [PATCH] Bug 6030 follow-up fix SQL error The <<'END_SQL' doesn't expand variables. So $date stay as $date, resulting in a nasty error DBD::mysql::st execute failed: Unknown column '$date' in 'field list' at misc/cronjobs/overdue_notices.pl line 505. --- misc/cronjobs/overdue_notices.pl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index 2b8f368..2a90c10 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -404,15 +404,15 @@ foreach my $branchcode (@branches) { $verbose and warn sprintf "branchcode : '%s' using %s\n", $branchcode, $admin_email_address; - my $sth2 = $dbh->prepare( <<'END_SQL' ); -SELECT biblio.title as "biblio.title", biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue + my $sth2 = $dbh->prepare( " +SELECT biblio.title as 'biblio.title', biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue FROM issues,items,biblio, biblioitems WHERE items.itemnumber=issues.itemnumber AND biblio.biblionumber = items.biblionumber AND biblio.biblionumber = biblioitems.biblionumber AND issues.borrowernumber = ? AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? -END_SQL +"); my $query = "SELECT * FROM overduerules WHERE delay1 IS NOT NULL AND branchcode = ? "; $query .= " AND categorycode IN (".join( ',' , ('?') x @myborcat ).") " if (@myborcat); @@ -505,7 +505,7 @@ END_SQL $sth2->execute(@params); $verbose and warn "STH2 PARAMS: borrowernumber = $borrowernumber, mindays = $mindays, maxdays = $maxdays returns ".$sth2->rows." rows"; my $itemcount = 0; - my $titles; + my $titles=''; if ($htmlfilename) { $titles = ""; $titles .= "
" . join( "", @$columns_def_hashref{@item_content_fields} ); -- 1.7.9.5