Bugzilla – Attachment 127777 Details for
Bug 29513
Accessibility: Staff Client - Convert remaining breadcrumbs sections from div to nav blocks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29513: Convert remaining breadcrumbs div blocks into nav
Bug-29513-Convert-remaining-breadcrumbs-div-blocks.patch (text/plain), 5.04 KB, created by
Andreas Roussos
on 2021-11-18 09:09:33 UTC
(
hide
)
Description:
Bug 29513: Convert remaining breadcrumbs div blocks into nav
Filename:
MIME Type:
Creator:
Andreas Roussos
Created:
2021-11-18 09:09:33 UTC
Size:
5.04 KB
patch
obsolete
>From d64bd127b7be89afa871864164283e392bf84b61 Mon Sep 17 00:00:00 2001 >From: Andreas Roussos <a.roussos@dataly.gr> >Date: Thu, 18 Nov 2021 09:37:01 +0100 >Subject: [PATCH] Bug 29513: Convert remaining breadcrumbs div blocks into nav > >As per https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846#c0, >breadcrumbs should adhere to the WAI-ARIA Authoring Practices. Most Staff >Client template files have already been fixed, but there were a few that >were missed. > >This patch fixes that. > >Test plan: >1) Apply this patch. >2) Visit these pages in the Staff Client: > Home > Acquisitions > TestVendor > Basket TestBasket (1) for TestVendor (*) > Home > Administration > Set library checkin and transfer policy (**) > Home > Patrons > Merge patron records (***) > ...and confirm that the breadcrumbs display correctly. > > (*) Can be accessed by creating a test basket for a test vendor > (**) Can be found under Administration -> Patrons and circulation > (***) Can be found by trying to merge two Patron records >--- > .../prog/en/modules/acqui/addorderiso2709.tt | 22 ++++++++++++++++++- > .../prog/en/modules/admin/transfer_limits.tt | 15 ++++++++++++- > .../prog/en/modules/members/merge-patrons.tt | 14 +++++++++++- > 3 files changed, 48 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index d80aaef044..15d25f369d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -23,7 +23,27 @@ Batch list > <body id="acq_addorderiso2709" class="acq"> > [% INCLUDE 'header.inc' %] > [% INCLUDE 'acquisitions-search.inc' %] >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> › <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | html %]">[% booksellername | html %]</a> › <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | html %]">Basket [% basketno | html %]</a> › Add orders from MARC file</div> >+ >+ <nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >+ <ol> >+ <li> >+ <a href="/cgi-bin/koha/mainpage.pl">Home</a> >+ </li> >+ <li> >+ <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> >+ </li> >+ <li> >+ <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | html %]">[% booksellername | html %]</a> >+ </li> >+ <li> >+ <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | html %]">Basket [% basketno | html %]</a> >+ </li> >+ <li> >+ <a href="#" aria-current="page">Add orders from MARC file</a> >+ </li> >+ </ol> >+ </nav> >+ > <div class="container-fluid"> > <div class="row"> > <div class="col-sm-6 col-sm-offset-3 col-md-8 col-md-offset-2"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt >index 534d384bba..595f2d841a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt >@@ -19,7 +19,20 @@ > [% INCLUDE 'header.inc' %] > [% INCLUDE 'prefs-admin-search.inc' %] > >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> › Set library checkin and transfer policy</div> >+<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >+ <ol> >+ <li> >+ <a href="/cgi-bin/koha/mainpage.pl">Home</a> >+ </li> >+ <li> >+ <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> >+ </li> >+ <li> >+ <a href="#" aria-current="page">Set library checkin and transfer policy</a> >+ </a> >+ </li> >+ </ol> >+</nav> > > <div class="main container-fluid"> > <div class="row"> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt >index b9bb5071c2..69fe1802b9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/merge-patrons.tt >@@ -79,7 +79,19 @@ > [% END %] > [% END %] > >-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> › Merge patron records</div> >+<nav id="breadcrumbs" aria-label="Breadcrumb" class="breadcrumb"> >+ <ol> >+ <li> >+ <a href="/cgi-bin/koha/mainpage.pl">Home</a> >+ </li> >+ <li> >+ <a href="/cgi-bin/koha/members/members-home.pl">Patrons</a> >+ </li> >+ <li> >+ <a href="#" aria-current="page">Merge patron records</a> >+ </li> >+ </ol> >+</nav> > > <div class="main container-fluid"> > <div class="row"> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29513
:
127777
|
127786
|
127862
|
127863