Bugzilla – Attachment 127853 Details for
Bug 29496
Can't save an order with mandatory items subfields
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29496: (bug 27526 follow-up) Fix item form validation
Bug-29496-bug-27526-follow-up-Fix-item-form-valida.patch (text/plain), 2.87 KB, created by
Marion Durand
on 2021-11-19 10:07:44 UTC
(
hide
)
Description:
Bug 29496: (bug 27526 follow-up) Fix item form validation
Filename:
MIME Type:
Creator:
Marion Durand
Created:
2021-11-19 10:07:44 UTC
Size:
2.87 KB
patch
obsolete
>From 6b7c0817ac54f79a81a73e110f0c47599f73323f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 17 Nov 2021 15:48:48 +0100 >Subject: [PATCH] Bug 29496: (bug 27526 follow-up) Fix item form validation > >The validation of the forms were blocked with "X item mandatory fields >empty" when at least one dropdown list subfield was marked as mandatory. > >We need to add the 'input_marceditor' class to the select (does it >actually make sense? select vs input...) > >Caused by > commit 6ed29bccef590a1bc5e4cea175b41b8024483320 > Bug 27526: Fix mandatory and important checks >Which lamentably failed as it was stating: >"Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones" > >Signed-off-by: Marion Durand <marion.durand@biblibre.com> >--- > .../intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt | 2 +- > .../intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >index d80aaef044..9ae96ef3a3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt >@@ -295,7 +295,7 @@ Batch list > [% END %] > > [% IF ( iteminformatio.marc_value.type == 'select' ) %] >- <select name="field_value"> >+ <select name="field_value" class="input_marceditor"> > [% FOREACH value IN iteminformatio.marc_value.values %] > [% IF ( value == iteminformatio.marc_value.default ) %] > <option value="[% value | html %]" selected="selected">[% iteminformatio.marc_value.labels.$value | html %]</option> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt >index cff769758b..c8a3b1fd24 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt >@@ -13,7 +13,7 @@ > <label>[% iteminfo.subfield | html %] - [% iteminfo.marc_lib | $raw %]</label> > [% END %] > [% IF ( iteminfo.marc_value.type == 'select' ) %] >- <select name="field_value"> >+ <select name="field_value" class="input_marceditor"> > [% FOREACH value IN iteminfo.marc_value.values %] > [% IF ( value == iteminfo.marc_value.default ) %] > <option value="[% value | html %]" selected="selected">[% iteminfo.marc_value.labels.$value | html %]</option> >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29496
:
127733
|
127780
|
127781
|
127853
|
127854
|
127855
|
136057