Bugzilla – Attachment 127876 Details for
Bug 29529
Fix \n in hint on Koha to MARC mappings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29529: Fix \n in hint on Koha to MARC mappings
Bug-29529-Fix-n-in-hint-on-Koha-to-MARC-mappings.patch (text/plain), 2.67 KB, created by
Owen Leonard
on 2021-11-19 15:00:50 UTC
(
hide
)
Description:
Bug 29529: Fix \n in hint on Koha to MARC mappings
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2021-11-19 15:00:50 UTC
Size:
2.67 KB
patch
obsolete
>From 682cdefb9d8896794b9c9bf1629fa6f5474c120a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 19 Nov 2021 14:48:49 +0000 >Subject: [PATCH] Bug 29529: Fix \n in hint on Koha to MARC mappings > >This patch breaks up a translatable string so that "\n" is excluded from >what is translated. > >Unrelated: Capitalization is corrected on an instance of the phrase >"Koha to MARC Mappings." > >To test, apply the patch and go to Administration -> Koha to MARC >mapping. > >- The breadcrumb for the current page should have correct capitalization > ("mapping" instead of "Mapping"). >- Click the "Add" button for any Koha field. The dialog should display > correctly: > > Adding a mapping for: biblio.abstract. > Please enter field tag and subfield code, separated by a comma. (For > control fields: add '@' as subfield code.) > The change will be applied immediately. > >Test the way the po file is updated: > > > cd misc/translator > > perl translate update en-GB (for example) > - Open the updated po file, en-GB-staff-prog.po > - You should find these lines: > > SCRIPT > koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 > msgid "The change will be applied immediately." > msgstr "" >--- > .../intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt >index efdea290c8..c3aa75586e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt >@@ -19,7 +19,7 @@ > <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> > </li> > <li> >- <a href="#" aria-current="page">Koha to MARC Mapping</a> >+ <a href="#" aria-current="page">Koha to MARC mapping</a> > </li> > </ol> > </nav> >@@ -85,7 +85,7 @@ > [% Asset.js("js/admin-menu.js") | $raw %] > <script> > function AddFld(kohafield) { >- var fieldstr = prompt( _("Adding a mapping for: %s.").format(kohafield) + "\n" + _("Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.)\nThe change will be applied immediately.") ); >+ var fieldstr = prompt( _("Adding a mapping for: %s.").format(kohafield) + "\n" + _("Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.)") + "\n" + _("The change will be applied immediately.") ); > var temp = fieldstr.split(','); > if( temp.length == 2 ) { > $('#add_field').val( kohafield+','+fieldstr ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29529
:
127876
|
128015
|
128027