View | Details | Raw Unified | Return to bug 29387
Collapse All | Expand All

(-)a/Koha/BackgroundJob/BatchUpdateAuthority.pm (-1 / +1 lines)
Lines 90-96 sub process { Link Here
90
                type => 'error',
90
                type => 'error',
91
                code => 'authority_not_modified',
91
                code => 'authority_not_modified',
92
                authid => $authid,
92
                authid => $authid,
93
                error => ($@ ? $@ : 0),
93
                error => ($@ ? "$@" : 0),
94
            };
94
            };
95
        } else {
95
        } else {
96
            push @messages, {
96
            push @messages, {
(-)a/Koha/BackgroundJob/BatchUpdateBiblio.pm (-1 / +1 lines)
Lines 95-101 sub process { Link Here
95
                type => 'error',
95
                type => 'error',
96
                code => 'biblio_not_modified',
96
                code => 'biblio_not_modified',
97
                biblionumber => $biblionumber,
97
                biblionumber => $biblionumber,
98
                error => ($@ ? $@ : $error),
98
                error => ($@ ? "$@" : $error),
99
            };
99
            };
100
        } else {
100
        } else {
101
            push @messages, {
101
            push @messages, {
(-)a/t/db_dependent/Koha/BackgroundJobs/BatchUpdateBiblio.t (-1 / +74 lines)
Line 0 Link Here
0
- 
1
#!/usr/bin/perl
2
3
# Copyright 2021 Koha Development team
4
#
5
# This file is part of Koha
6
#
7
# Koha is free software; you can redistribute it and/or modify it
8
# under the terms of the GNU General Public License as published by
9
# the Free Software Foundation; either version 3 of the License, or
10
# (at your option) any later version.
11
#
12
# Koha is distributed in the hope that it will be useful, but
13
# WITHOUT ANY WARRANTY; without even the implied warranty of
14
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15
# GNU General Public License for more details.
16
#
17
# You should have received a copy of the GNU General Public License
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
20
use Modern::Perl;
21
22
use Test::More tests => 1;
23
use Test::MockModule;
24
use JSON qw( encode_json decode_json );
25
26
use Koha::Database;
27
use Koha::BackgroundJobs;
28
use Koha::BackgroundJob::BatchUpdateBiblio;
29
use Koha::Exceptions::Exception;
30
use t::lib::TestBuilder;
31
32
my $schema = Koha::Database->new->schema;
33
34
my $builder = t::lib::TestBuilder->new;
35
36
subtest "Exceptions must be stringified" => sub {
37
    plan tests => 1;
38
39
    $schema->storage->txn_begin;
40
41
    my $C4_biblio_module = Test::MockModule->new('C4::Biblio');
42
    $C4_biblio_module->mock( 'ModBiblio',
43
        sub { Koha::Exceptions::Exception->throw("It didn't work"); } );
44
45
    my $biblio = $builder->build_sample_biblio;
46
    my $patron = $builder->build_object( { class => 'Koha::Patrons' } );
47
    my $job    = Koha::BackgroundJob::BatchUpdateBiblio->new(
48
        {
49
            status         => 'new',
50
            size           => 1,
51
            borrowernumber => $patron->borrowernumber,
52
            type           => 'batch_biblio_record_modification',
53
            data           => encode_json {
54
                record_ids => [ $biblio->biblionumber ],
55
            }
56
        }
57
    )->store;
58
    $job = Koha::BackgroundJobs->find( $job->id );
59
    $job->process(
60
        { job_id => $job->id, record_ids => [ $biblio->biblionumber ] } );
61
62
    my $data = decode_json $job->get_from_storage->data;
63
    is_deeply(
64
        $data->{messages}->[0],
65
        {
66
            biblionumber => $biblio->biblionumber,
67
            code         => 'biblio_not_modified',
68
            error        => "It didn't work",
69
            type         => "error"
70
        }
71
    );
72
73
    $schema->storage->txn_rollback;
74
};

Return to bug 29387