From fb0aa0f46a47b9f99cc1ed20ccf1ed674cdbc663 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 24 Nov 2021 09:26:38 +0100 Subject: [PATCH] Bug 29565: Prevent regressions.t to fail on slow boxes It's failing randomly on some Jenkins' nodes # Failed test 'Encoding in session variables' # at t/db_dependent/selenium/regressions.t line 300. Can't call method "get_text" on an undefined value at t/db_dependent/selenium/regressions.t line 285. It can be recreated locally with the following changes: @ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; } @ t/lib/Selenium.pm:50 @ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(1000); return $self; } This patch suggests to simply double the timeout. --- t/lib/Selenium.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm index 8460d9d646a..b49bc730b02 100644 --- a/t/lib/Selenium.pm +++ b/t/lib/Selenium.pm @@ -47,7 +47,7 @@ sub new { ); bless $self, $class; $self->add_error_handler; - $self->driver->set_implicit_wait_timeout(5000); + $self->driver->set_implicit_wait_timeout(10000); return $self; } -- 2.25.1