Bugzilla – Attachment 128007 Details for
Bug 28445
Use the task queue for the batch delete and update items tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 28445: Add diag for failing test
Bug-28445-Add-diag-for-failing-test.patch (text/plain), 1.79 KB, created by
Jonathan Druart
on 2021-11-25 12:55:20 UTC
(
hide
)
Description:
Bug 28445: Add diag for failing test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-11-25 12:55:20 UTC
Size:
1.79 KB
patch
obsolete
>From c70de8c5305700cce9a6fe9a6f75c2cf53be02f1 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 28 Oct 2021 12:15:17 +0200 >Subject: [PATCH] Bug 28445: Add diag for failing test > >Temporary patch to help trying to fix the following random error: > # Failed test 'Item types should be sorted by description and an empty entries should be shown' > # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 121. > # Structures begin differing at: > # $got->[12] = 'Be9T9FH5aO' > # $expected->[12] = 'REF' > # Looks like you failed 1 test of 2. > > # Failed test 'itemtypes' > # at t/db_dependent/Koha/UI/Form/Builder/Item.t line 130. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Koha/UI/Form/Builder/Item.t | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/UI/Form/Builder/Item.t b/t/db_dependent/Koha/UI/Form/Builder/Item.t >index f2366dbe103..ead8517d328 100755 >--- a/t/db_dependent/Koha/UI/Form/Builder/Item.t >+++ b/t/db_dependent/Koha/UI/Form/Builder/Item.t >@@ -17,6 +17,7 @@ > > use Modern::Perl; > use Test::More tests => 7; >+use Data::Dumper qw( Dumper ); > use utf8; > > use List::MoreUtils qw( uniq ); >@@ -122,7 +123,9 @@ subtest 'authorised values' => sub { > $itemtypes->as_list > ], > "Item types should be sorted by description and an empty entries should be shown" >- ); >+ ) >+ or diag("Itemtypes details: ".Dumper($subfield->{marc_value}->{values}, [map { $_->itemtype } $itemtypes->as_list])); >+ > is_deeply( $subfield->{marc_value}->{labels}, > { map { $_->itemtype => $_->description } $itemtypes->as_list }, > 'Labels should be correctly displayed' >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 28445
:
121372
|
123221
|
123222
|
123223
|
123224
|
123225
|
123226
|
123227
|
123228
|
123229
|
123239
|
123240
|
125801
|
125802
|
125803
|
125804
|
125805
|
125808
|
125810
|
125811
|
125812
|
125817
|
125865
|
126046
|
126047
|
126136
|
126137
|
126138
|
126139
|
126140
|
126141
|
126142
|
126217
|
126218
|
126219
|
126223
|
126328
|
126329
|
126330
|
126331
|
126332
|
126333
|
126334
|
126335
|
126336
|
126337
|
126338
|
126339
|
126352
|
126353
|
126354
|
126355
|
126356
|
126357
|
126358
|
126359
|
126360
|
126361
|
126362
|
126363
|
126364
|
126365
|
126366
|
126367
|
126374
|
126375
|
126376
|
126377
|
126378
|
126379
|
126380
|
126381
|
126382
|
126383
|
126384
|
126385
|
126386
|
126387
|
126388
|
126389
|
127033
|
127037
|
127038
|
127039
| 128007 |
128008
|
128009