From 13f12c072cc26c7cda3ded1e7a60466284722cb6 Mon Sep 17 00:00:00 2001
From: Andrew Nugged <nugged@gmail.com>
Date: Wed, 1 Dec 2021 17:33:08 +0200
Subject: [PATCH] Bug 20447: (QA follow-up) undefined $mode warning remove

When POST /intranet/cataloguing/addholding.pl happens from any
/cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=XXX&holding_id=YYY
it has "$mode" undefined but comes to code "$mode ne 'popup'" hence the warning.
---
 cataloguing/addholding.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cataloguing/addholding.pl b/cataloguing/addholding.pl
index 71bd3503d1..c4faa7cb5e 100755
--- a/cataloguing/addholding.pl
+++ b/cataloguing/addholding.pl
@@ -568,7 +568,7 @@ my $error = $input->param('error');
 my $biblionumber  = $input->param('biblionumber');
 my $holding_id    = $input->param('holding_id'); # if holding_id exists, it's a modification, not a new holding.
 my $op            = $input->param('op') // q{};
-my $mode          = $input->param('mode');
+my $mode          = $input->param('mode') // q{};
 my $frameworkcode = $input->param('frameworkcode');
 my $redirect      = $input->param('redirect');
 my $searchid      = $input->param('searchid') // "";
-- 
2.30.1 (Apple Git-130)