@@ -, +, @@
---
C4/Reserves.pm | 18 +++++++++++-------
.../intranet-tmpl/prog/en/includes/holds_table.inc | 4 ++--
2 files changed, 13 insertions(+), 9 deletions(-)
--- a/C4/Reserves.pm
+++ a/C4/Reserves.pm
@@ -1127,9 +1127,11 @@ sub ModReserveFill {
if C4::Context->preference('HoldsLog');
# if this hold was part of a group, cancel other holds in the group
- my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id });
- foreach my $h ( @holds ) {
- $h->cancel unless $h->reserve_id == $hold->reserve_id;
+ if ( $hold->hold_group_id ) {
+ my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id });
+ foreach my $h ( @holds ) {
+ $h->cancel unless $h->reserve_id == $hold->reserve_id;
+ }
}
# FIXME Must call Koha::Hold->cancel ? => No, should call ->filled and add the correct log
@@ -1240,10 +1242,12 @@ sub ModReserveAffect {
$transfer->receive if $transfer;
# if this hold was part of a group, cancel other holds in the group
- my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id });
- foreach my $h ( @holds ) {
- push @reserve_ids, $h->reserve_id;
- $h->cancel unless $h->reserve_id == $hold->reserve_id;
+ if ( $hold->hold_group_id ) {
+ my @holds = Koha::Holds->search({ hold_group_id => $hold->hold_group_id });
+ foreach my $h ( @holds ) {
+ push @reserve_ids, $h->reserve_id;
+ $h->cancel unless $h->reserve_id == $hold->reserve_id;
+ }
}
}
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
+++ a/koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc
@@ -177,9 +177,9 @@
[%- IF hold.non_priority -%]
Non priority hold
[%- END -%]
- [% IF hold.hold_group_id %]
+ [%- IF hold.hold_group_id -%]