Bugzilla – Attachment 128270 Details for
Bug 29646
Bad or repeated opac-password-recovery attempt crashes on wrong borrowernumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29646: Fix undefined category crash in opac-password-recovery
Bug-29646-Fix-undefined-category-crash-in-opac-pas.patch (text/plain), 1.52 KB, created by
Marcel de Rooy
on 2021-12-06 08:34:30 UTC
(
hide
)
Description:
Bug 29646: Fix undefined category crash in opac-password-recovery
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2021-12-06 08:34:30 UTC
Size:
1.52 KB
patch
obsolete
>From 5d958fcc9d6d9e1ffe17fcb729cfd6ffd0d3d39d Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 6 Dec 2021 08:31:48 +0000 >Subject: [PATCH] Bug 29646: Fix undefined category crash in > opac-password-recovery >Content-Type: text/plain; charset=utf-8 > >The crash is a result of a not found borrower. This is typically >a bad or repeated recovery attempt. > >Test plan: >Do a password recovery. >Use the mailed URL twice. >Without this patch, the second attempt crashes. >With this patch, the second attempt shows an error dialog. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-password-recovery.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/opac/opac-password-recovery.pl b/opac/opac-password-recovery.pl >index 9ee1278c0a..d1cdde3897 100755 >--- a/opac/opac-password-recovery.pl >+++ b/opac/opac-password-recovery.pl >@@ -211,8 +211,8 @@ elsif ($uniqueKey) { #reset password form > username => $username, > errLinkNotValid => $errLinkNotValid, > hasError => ( $errLinkNotValid ? 1 : 0 ), >- minPasswordLength => $borrower->category->effective_min_password_length, >- RequireStrongPassword => $borrower->category->effective_require_strong_password >+ minPasswordLength => $borrower ? $borrower->category->effective_min_password_length: undef, >+ RequireStrongPassword => $borrower ? $borrower->category->effective_require_strong_password: undef, > ); > } > else { #password recovery form (to send email) >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29646
:
128270
|
129370