Bugzilla – Attachment 128309 Details for
Bug 29043
Items are processed but not displayed on request.pl before a patron is selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29043: Remaining bug is the incorrect title "Place a hold on No title"
Bug-29043-Remaining-bug-is-the-incorrect-title-Pla.patch (text/plain), 1.47 KB, created by
Samu Heiskanen
on 2021-12-07 08:48:44 UTC
(
hide
)
Description:
Bug 29043: Remaining bug is the incorrect title "Place a hold on No title"
Filename:
MIME Type:
Creator:
Samu Heiskanen
Created:
2021-12-07 08:48:44 UTC
Size:
1.47 KB
patch
obsolete
>From 34ea69e76da663042e0ecd406dea97d6c6837524 Mon Sep 17 00:00:00 2001 >From: Samu Heiskanen <samu.heiskanen@hypernova.fi> >Date: Tue, 7 Dec 2021 08:44:43 +0000 >Subject: [PATCH] Bug 29043: Remaining bug is the incorrect title "Place a hold > on No title" > >I tried to fix this bug with my previous attempt, but introduced a new bug. > >I return the line: > >my $biblio = Koha::Biblios->find( $biblionumber ); > >to it's previous place and just copy it to the end of the foreach loop. > >The display infos for template will remain as they were in my first attempt. > >Hope this fix works properly. >--- > reserve/request.pl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 4f8dd8d25e..72a43b1098 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -315,14 +315,12 @@ my $itemdata_ccode = 0; > my @biblioloop = (); > my $reserveloop = 0; > my $no_reserves_allowed = 0; >- >-my $biblio = Koha::Biblios->find( $biblionumber ); >- > foreach my $biblionumber (@biblionumbers) { > next unless $biblionumber =~ m|^\d+$|; > > my %biblioloopiter = (); > >+ my $biblio = Koha::Biblios->find( $biblionumber ); > unless ($biblio) { > $biblioloopiter{noitems} = 1; > $template->param('nobiblio' => 1); >@@ -737,6 +735,8 @@ foreach my $biblionumber (@biblionumbers) { > push @biblioloop, \%biblioloopiter; > } > >+my $biblio = Koha::Biblios->find( $biblionumber ); >+ > # display infos > $template->param( > reserveloop => 1, >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29043
:
124941
|
125060
|
127731
|
127732
|
128254
|
128309
|
128336
|
128337
|
128338
|
128339
|
128340
|
128421
|
128422
|
128423
|
128474
|
128475
|
128476
|
128971
|
128972
|
128973
|
129200
|
129498
|
129530
|
129531
|
129820
|
129821
|
129915
|
129916
|
129949
|
129950