From 6df13481501a69874da0f266f2f9f1cf5452496d Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 9 Dec 2021 16:32:50 -0300 Subject: [PATCH] Bug 28377: (QA follow-up) Fallback error handling The code only dealt with 404, this patch makes it have a fallback message for failure codes. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize --- koha-tmpl/intranet-tmpl/prog/js/holds.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js index d957c46af1..110d142fc9 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/holds.js +++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js @@ -328,8 +328,11 @@ $(document).ready(function() { }).error(function (jqXHR, textStatus, errorThrown) { if (jqXHR.status === 404) { alert(__("Unable to resume, hold not found")); - holdsTable.api().ajax.reload(); } + else { + alert(_("Your request could not be processed. Check the logs")); + } + holdsTable.api().ajax.reload(); }); }); @@ -413,9 +416,12 @@ $(document).ready(function() { holdsTable.api().ajax.reload(); }).error(function (jqXHR, textStatus, errorThrown) { if (jqXHR.status === 404) { - alert(__("Unable to resume, hold not found")); - holdsTable.api().ajax.reload(); + alert(__("Unable to suspend, hold not found")); } + else { + alert(_("Your request could not be processed. Check the logs")); + } + holdsTable.api().ajax.reload(); }).done(function() { $("#suspend-modal-until").val(""); // clean the input $('#suspend-modal').modal('hide'); -- 2.20.1