Bugzilla – Attachment 128426 Details for
Bug 29571
Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt
Bug-29571-follow-up-Fix-display-of-pending-suggest.patch (text/plain), 2.07 KB, created by
Andreas Roussos
on 2021-12-13 07:09:56 UTC
(
hide
)
Description:
Bug 29571: (follow-up) Fix display of pending suggestions in acqui-home.tt
Filename:
MIME Type:
Creator:
Andreas Roussos
Created:
2021-12-13 07:09:56 UTC
Size:
2.07 KB
patch
obsolete
>From a75d7a6c744312712e9489a4c07c84be221e8310 Mon Sep 17 00:00:00 2001 >From: Andreas Roussos <a.roussos@dataly.gr> >Date: Mon, 13 Dec 2021 07:49:07 +0100 >Subject: [PATCH] Bug 29571: (follow-up) Fix display of pending suggestions in > acqui-home.tt > >In addition to the Staff Client's home page, the number of pending >suggestions is also displayed in Home > Acquisitions. Currently, >these are only displayed if there are pending suggestions at the >logged in library. However, suggestions should always be displayed. > >This follow-up patch fixes that, and also removes a template variable >(`suggestion`) that is no longer in use (removed as part of Bug 4331, >commit 70af4593722ce2f3debd4f6d2c251ad29008b923). > >Test plan: >1) Create a suggestion for Library A. >2) Go to Home > Acquisitions while logged in at Library B. > Without this patch, nothing is displayed regarding suggestions. >3) Apply this patch. Notice how suggestion information is shown, like: > "Manage suggestions: Library B: 0 / All libraries: 1" > If you change the library to Library A, you should get: > "Manage suggestions: Library A: 1" >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >index 02f0bbac29..833c27a020 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt >@@ -41,7 +41,7 @@ > [% END %] > [% END %] > <div class="row"> >- [% IF ( suggestion && suggestions_count ) %] >+ [% IF ( suggestions_count || all_pendingsuggestions ) %] > <div class="col-sm-6"> > [% ELSE %] > <div class="col-sm-12"> >@@ -58,7 +58,7 @@ > </div> > </div> > >-[% IF ( CAN_user_suggestions_suggestions_manage && suggestion && suggestions_count ) %] >+[% IF ( CAN_user_suggestions_suggestions_manage && ( suggestions_count || all_pendingsuggestions ) ) %] > <div class="col-sm-6"> > <div id="acqui_acqui_home_suggestions"> > <fieldset> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29571
:
128010
|
128060
|
128271
|
128399
|
128426
|
128473
|
128710
|
128711