From 599d4ba0f5330906c61c61ba38ea2859da8594b0 Mon Sep 17 00:00:00 2001 From: Alex Arnaud Date: Fri, 5 Mar 2021 14:22:53 +0100 Subject: [PATCH] Bug 17656: QA warnings fixes Signed-off-by: Amarangi Signed-off-by: Victor Grousset/tuxayo --- Koha/Subscription.pm | 5 ++--- t/Serials/IssueNumber.t | 0 t/db_dependent/Koha/Subscription/GuessEnddate.t | 0 t/db_dependent/Koha/Subscription/Irregularities.t | 0 t/db_dependent/Serials/SubscriptionIrregularity.t | 0 5 files changed, 2 insertions(+), 3 deletions(-) mode change 100644 => 100755 t/Serials/IssueNumber.t mode change 100644 => 100755 t/db_dependent/Koha/Subscription/GuessEnddate.t mode change 100644 => 100755 t/db_dependent/Koha/Subscription/Irregularities.t mode change 100644 => 100755 t/db_dependent/Serials/SubscriptionIrregularity.t diff --git a/Koha/Subscription.pm b/Koha/Subscription.pm index f042510c71..68a09d99a5 100644 --- a/Koha/Subscription.pm +++ b/Koha/Subscription.pm @@ -21,7 +21,6 @@ use Modern::Perl; use C4::Serials::Frequency; -use C4::Serials qw(issue_number); use Koha::Database; use Koha::Biblios; @@ -267,7 +266,7 @@ sub guess_irregularities { my $date = $nextexpected->{planneddate}; my ($issuenumber) = C4::Serials::GetFictiveIssueNumber($self->unblessed, $date); - my $dow = issue_number( dt_from_string($date), $frequency->unit ); + my $dow = C4::Serials::issue_number( dt_from_string($date), $frequency->unit ); if ( defined( $permanent_irregularities{$dow} ) ) { push @irregularities, $issuenumber; @@ -276,7 +275,7 @@ sub guess_irregularities { while ( Delta_Days( split(/-/, $date), split(/-/, $enddate) ) >= 0 ) { $issuenumber++; $date = C4::Serials::GetNextDate($self->unblessed, $date); - $dow = issue_number( dt_from_string($date), $frequency->unit ); + $dow = C4::Serials::issue_number( dt_from_string($date), $frequency->unit ); if ( defined( $permanent_irregularities{$dow} ) ) { push @irregularities, $issuenumber; diff --git a/t/Serials/IssueNumber.t b/t/Serials/IssueNumber.t old mode 100644 new mode 100755 diff --git a/t/db_dependent/Koha/Subscription/GuessEnddate.t b/t/db_dependent/Koha/Subscription/GuessEnddate.t old mode 100644 new mode 100755 diff --git a/t/db_dependent/Koha/Subscription/Irregularities.t b/t/db_dependent/Koha/Subscription/Irregularities.t old mode 100644 new mode 100755 diff --git a/t/db_dependent/Serials/SubscriptionIrregularity.t b/t/db_dependent/Serials/SubscriptionIrregularity.t old mode 100644 new mode 100755 -- 2.25.1