Bugzilla – Attachment 128568 Details for
Bug 29679
Reports result menu shows too many dividers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29679: Remove redundant divider element from reports menu
Bug-29679-Remove-redundant-divider-element-from-re.patch (text/plain), 3.62 KB, created by
Jonathan Druart
on 2021-12-15 13:56:33 UTC
(
hide
)
Description:
Bug 29679: Remove redundant divider element from reports menu
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2021-12-15 13:56:33 UTC
Size:
3.62 KB
patch
obsolete
>From 3f84151afca22186851c867361ef679ff66f1263 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 13 Dec 2021 12:16:06 +0000 >Subject: [PATCH] Bug 29679: Remove redundant divider element from reports menu > >The SQL report batch operations dropdown menu has divider list items >which add a border between sections (Bibliographic records, item >records, etc.). This element is redundant because the sections have >"headers" which also add a border. > >This patch removes them. > >To test, apply the patch and run an SQL report which will return results >that trigger the batch modification menu: > >SELECT biblio.biblionumber , biblio.title, items.itemnumber, >items.itemcallnumber, items.barcode, borrowers.firstname, >borrowers.surname, borrowers.borrowernumber, borrowers.cardnumber >FROM issues >LEFT JOIN borrowers ON borrowers.borrowernumber=issues.borrowernumber >LEFT JOIN items ON issues.itemnumber=items.itemnumber >LEFT JOIN biblio ON items.biblionumber=biblio.biblionumber >ORDER BY RAND() > >There should be no double border in the menu. > >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 6 ------ > 1 file changed, 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 241d9b61595..18bea35dba7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1043,9 +1043,6 @@ > </li> > [% END %] > [% IF header_ro.has_itemnumbers && ( header_ro.cell == 'itemnumber' || header_types.item( header_ro.cell ) == 'itemnumber' ) %] >- [% IF ( batch_biblionumbers ) %] >- <li role="separator" class="divider"></li> >- [% END %] > <li class="dropdown-header">Item records</li> > <li> > <a href="#" data-submit="batch_item_modification" data-toggle="tooltip" data-placement="right" title="Send visible items to batch item modification" class="batch_op send_to_item_mod">Batch item modification</a> >@@ -1055,9 +1052,6 @@ > </li> > [% END %] > [% IF header_ro.cell == 'cardnumber' || header_types.item( header_ro.cell ) == 'cardnumber' %] >- [% IF ( batch_biblionumbers || batch_itemnumbers ) %] >- <li role="separator" class="divider"></li> >- [% END %] > <li class="dropdown-header">Patron records</li> > <li> > <a href="#" data-submit="batch_patron_modification" data-toggle="tooltip" data-placement="right" title="Send visible results to batch patron modification" class="batch_op send_to_patron_mod">Batch patron modification</a> >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29679
:
128408
|
128456
|
128479
| 128568