Bugzilla – Attachment 128683 Details for
Bug 29553
Holds: Can't call method "notforloan" on an undefined value when placing a hold
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29553: (QA follow-up) Check defined instead of evaluating as boolean
Bug-29553-QA-follow-up-Check-defined-instead-of-ev.patch (text/plain), 953 bytes, created by
Tomás Cohen Arazi
on 2021-12-17 15:54:49 UTC
(
hide
)
Description:
Bug 29553: (QA follow-up) Check defined instead of evaluating as boolean
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2021-12-17 15:54:49 UTC
Size:
953 bytes
patch
obsolete
>From 2448645fc35effc2399b2b3b6461579fc99fa541 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 17 Dec 2021 12:53:28 -0300 >Subject: [PATCH] Bug 29553: (QA follow-up) Check defined instead of evaluating > as boolean > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Reserves.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index 706721acab..1490d5aa88 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -1345,7 +1345,9 @@ sub IsAvailableForItemLevelRequest { > # FIXME - a lot of places in the code do this > # or something similar - need to be > # consolidated >- my $itemtype = $item->effective_itemtype or return 0; >+ my $itemtype = $item->effective_itemtype; >+ return 0 >+ unless defined $itemtype; > my $notforloan_per_itemtype = Koha::ItemTypes->find($itemtype)->notforloan; > > return 0 if >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29553
:
127925
|
128122
|
128681
|
128682
| 128683