Bugzilla – Attachment 128686 Details for
Bug 29729
If serials_stats.pl returns no results dataTables get angry
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29729: Build a tr for each subscription
Bug-29729-Build-a-tr-for-each-subscription.patch (text/plain), 1.68 KB, created by
Lucas Gass
on 2021-12-17 21:12:32 UTC
(
hide
)
Description:
Bug 29729: Build a tr for each subscription
Filename:
MIME Type:
Creator:
Lucas Gass
Created:
2021-12-17 21:12:32 UTC
Size:
1.68 KB
patch
obsolete
>From 50cbd4266c0ec7397f5dd5918bd85bf9945b0603 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 17 Dec 2021 21:09:19 +0000 >Subject: [PATCH] Bug 29729: Build a tr for each subscription > >To test: >1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. >2 Notice console error >3 If you run the report for a branch WITH subscriptions it works just fine. >4 Apply patch >5 Do 1 again, no console error and show no see 'No entries to show' >6 Make sure it also works when you have a few subscriptions for a branch as well >--- > .../intranet-tmpl/prog/en/modules/reports/serials_stats.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >index dd7c0e23ce..f8d2304cfc 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/serials_stats.tt >@@ -52,8 +52,8 @@ > </tr> > </thead> > <tbody> >- <tr> > [% FOREACH data IN datas %] >+ <tr> > <td><a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% data.aqbooksellerid | uri %]">[% data.name | html %]</a></td> > <td><a href="/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=[% data.subscriptionid | uri %]">[% data.title | html %]</a></td> > <td>[% data.subscriptionid | html %]</td> >@@ -68,7 +68,7 @@ > Expired > [% END %] > </td> >- </tr> >+ </tr> > [% END %] > </tr> > </tbody> >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29729
:
128686
|
128687
|
128699