View | Details | Raw Unified | Return to bug 20256
Collapse All | Expand All

(-)a/t/db_dependent/Koha/Patrons.t (-1 / +74 lines)
Lines 2325-2331 subtest 'filter_by_amount_owed' => sub { Link Here
2325
    is( $filtered->_resultset->as_subselect_rs->count, 1,
2325
    is( $filtered->_resultset->as_subselect_rs->count, 1,
2326
"filter_by_amount_owed({ more_than => 6.00, library => $library2->{branchcode} }) found one patron"
2326
"filter_by_amount_owed({ more_than => 6.00, library => $library2->{branchcode} }) found one patron"
2327
    );
2327
    );
2328
};
2329
2330
subtest 'libraries_where_can_edit_items + can_edit_item' => sub {
2331
    plan tests => 2;
2332
2333
    $schema->storage->txn_begin;
2334
    my $dbh = $schema->storage->dbh;
2335
2336
    $dbh->do("DELETE FROM library_groups");
2337
2338
    # group1
2339
    #   library_1A
2340
    #   library_1B
2341
    # group2
2342
    #   library_2A
2343
    my $group_1 = Koha::Library::Group->new( { title => 'TEST Group 1', ft_limit_item_editing => 1 } )->store;
2344
    my $group_2 = Koha::Library::Group->new( { title => 'TEST Group 2', ft_limit_item_editing => 1 } )->store;
2345
    my $library_1A = $builder->build( { source => 'Branch' } );
2346
    my $library_1B = $builder->build( { source => 'Branch' } );
2347
    my $library_2A = $builder->build( { source => 'Branch' } );
2348
    $library_1A = Koha::Libraries->find( $library_1A->{branchcode} );
2349
    $library_1B = Koha::Libraries->find( $library_1B->{branchcode} );
2350
    $library_2A = Koha::Libraries->find( $library_2A->{branchcode} );
2351
    Koha::Library::Group->new( { branchcode => $library_1A->branchcode, parent_id => $group_1->id } )->store;
2352
    Koha::Library::Group->new( { branchcode => $library_1B->branchcode, parent_id => $group_1->id } )->store;
2353
    Koha::Library::Group->new( { branchcode => $library_2A->branchcode, parent_id => $group_2->id } )->store;
2354
2355
    my $sth = C4::Context->dbh->prepare(q|INSERT INTO user_permissions( borrowernumber, module_bit, code ) VALUES (?, 9, ?)|); # 9 for editcatalogue
2356
    # 2 patrons from library_1A (group1)
2357
    # patron_1A_1 see patron's infos from outside its group
2358
    # Setting flags => undef to not be considered as superlibrarian
2359
    my $patron_1A_1 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2360
    $patron_1A_1 = Koha::Patrons->find( $patron_1A_1->{borrowernumber} );
2361
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_items' );
2362
    $sth->execute( $patron_1A_1->borrowernumber, 'edit_any_item' );
2363
    # patron_1A_2 can only see patron's info from its group
2364
    my $patron_1A_2 = $builder->build({ source => 'Borrower', value => { branchcode => $library_1A->branchcode, flags => undef, }});
2365
    $patron_1A_2 = Koha::Patrons->find( $patron_1A_2->{borrowernumber} );
2366
    $sth->execute( $patron_1A_2->borrowernumber, 'edit_items' );
2367
    # 1 patron from library_1B (group1)
2368
    my $patron_1B = $builder->build({ source => 'Borrower', value => { branchcode => $library_1B->branchcode, flags => undef, }});
2369
    $patron_1B = Koha::Patrons->find( $patron_1B->{borrowernumber} );
2370
    # 1 patron from library_2A (group2) can only see patron's info from its group
2371
    my $patron_2A = $builder->build({ source => 'Borrower', value => { branchcode => $library_2A->branchcode, flags => undef, }});
2372
    $patron_2A = Koha::Patrons->find( $patron_2A->{borrowernumber} );
2373
    $sth->execute( $patron_2A->borrowernumber, 'edit_items' );
2374
2375
    subtest 'libraries_where_can_edit_items' => sub {
2376
        plan tests => 3;
2328
2377
2378
        my @branchcodes;
2379
2380
        @branchcodes = $patron_1A_1->libraries_where_can_edit_items;
2381
        is_deeply( \@branchcodes, [], "patron_1A_1 has edit_any_item => No restrictions" );
2382
2383
        @branchcodes = $patron_1A_2->libraries_where_can_edit_items;
2384
        is_deeply( \@branchcodes, [ sort ( $library_1A->branchcode, $library_1B->branchcode ) ], "patron_1A_2 doesn't have edit_any_item => Can only edit items from its group" );
2385
2386
        @branchcodes = $patron_2A->libraries_where_can_edit_items;
2387
        is_deeply( \@branchcodes, [$library_2A->branchcode], "patron_2A doesn't have edit_any_item => Can only see patron's from its group" );
2388
    };
2389
2390
    subtest 'can_edit_item' => sub {
2391
        plan tests => 6;
2392
2393
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_1 });
2394
        is( $patron_1A_1->can_edit_item( $library_1A->id ), 1, "patron_1A_1 can see patron_1A_2, from its library" );
2395
        is( $patron_1A_1->can_edit_item( $library_1B->id ),   1, "patron_1A_1 can see patron_1B, from its group" );
2396
        is( $patron_1A_1->can_edit_item( $library_2A->id ),   1, "patron_1A_1 can see patron_1A_2, from another group" );
2397
2398
        t::lib::Mocks::mock_userenv({ patron => $patron_1A_2 });
2399
        is( $patron_1A_2->can_edit_item( $library_1A->id ),   1, "patron_1A_2 can see patron_1A_1, from its library" );
2400
        is( $patron_1A_2->can_edit_item( $library_1B->id ),   1, "patron_1A_2 can see patron_1B, from its group" );
2401
        is( $patron_1A_2->can_edit_item( $library_2A->id ),   0, "patron_1A_2 can NOT see patron_2A, from another group" );
2402
    };
2329
};
2403
};
2330
2404
2331
$schema->storage->txn_rollback;
2405
$schema->storage->txn_rollback;
2332
- 

Return to bug 20256