@@ -, +, @@
Uncaught TypeError: form.field_value is undefined
Focustag_952_subfield_p_878344
Focustag_952_subfield_p_878344_handler
jQuery 11
BindEventstag_952_subfield_p_878344
let loc = document.getElementsByName('items.homebranch')[0].value;
---
C4/Barcodes/ValueBuilder.pm | 26 +++++++------------
cataloguing/value_builder/barcode.pl | 1 -
cataloguing/value_builder/barcode_manual.pl | 1 -
.../prog/en/includes/html_helpers.inc | 1 +
t/db_dependent/Barcodes_ValueBuilder.t | 2 --
5 files changed, 11 insertions(+), 20 deletions(-)
--- a/C4/Barcodes/ValueBuilder.pm
+++ a/C4/Barcodes/ValueBuilder.pm
@@ -56,23 +56,17 @@ sub get_barcode {
$nextnum++;
$nextnum = sprintf("%0*d", "4",$nextnum);
$nextnum = $year . $month . $nextnum;
- my $scr = "
- var form = document.getElementById('f');
- if ( !form ) {
- form = document.getElementById('serials_edit');
- }
- if ( !form ) {
- form = document.getElementById('Aform');
- }
- for (i=0 ; i
{loctag}' && form.subfield[i].value == '$args->{locsubfield}') {
- fnum = i;
- }
+ my $scr = qq~
+ let elt = \$("#"+id);
+ let homebranch = elt.parents('fieldset.rows:first')
+ .find('input[name="kohafield"][value="items.homebranch"]')
+ .siblings("select")
+ .val();
+
+ if ( \$(elt).val() == '' ) {
+ \$(elt).val(homebranch + '$nextnum');
}
- if (\$('#' + id).val() == '') {
- \$('#' + id).val(form.field_value[fnum].value + '$nextnum');
- }
- ";
+ ~;
return $nextnum, $scr;
}
--- a/cataloguing/value_builder/barcode.pl
+++ a/cataloguing/value_builder/barcode.pl
@@ -37,7 +37,6 @@ my $builder = sub {
# find today's date
($args{year}, $args{mon}, $args{day}) = split('-', output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }));
($args{tag},$args{subfield}) = GetMarcFromKohaField( "items.barcode" );
- ($args{loctag},$args{locsubfield}) = GetMarcFromKohaField( "items.homebranch" );
my $nextnum;
my $scr;
--- a/cataloguing/value_builder/barcode_manual.pl
+++ a/cataloguing/value_builder/barcode_manual.pl
@@ -38,7 +38,6 @@ my $builder = sub {
# find today's date
($args{year}, $args{mon}, $args{day}) = split('-', output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 1 }));
($args{tag},$args{subfield}) = GetMarcFromKohaField( "items.barcode" );
- ($args{loctag},$args{locsubfield}) = GetMarcFromKohaField( "items.homebranch" );
my $nextnum;
my $scr;
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
+++ a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
@@ -148,6 +148,7 @@
[% END %]
+ [%# We should not need that but all item forms are not rewritten yet %]
--- a/t/db_dependent/Barcodes_ValueBuilder.t
+++ a/t/db_dependent/Barcodes_ValueBuilder.t
@@ -61,8 +61,6 @@ my %args = (
day => '30',
tag => '952',
subfield => 'p',
- loctag => '952',
- locsubfield => 'a'
);
my ($nextnum, $scr) = C4::Barcodes::ValueBuilder::incremental::get_barcode(\%args);
--