From 3379805d1c586c0da658a1858949f4145e3cf736 Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Mon, 20 Sep 2021 12:33:05 -1000
Subject: [PATCH] Bug 29066: Remove text in OPAC search form and use Font
 Awesome icons

In modern front-end websites, first think you see in header region is an large input text with a search icon.
No need to say it is a search form.
We still tell it in 'title' attribut for accessibility.

This patch removes 'Search' text.
If 'my library first' feature is enabled, shows a text in title of a
question mark icon.
In submit button, replaces 'Go' with a seach icon and add title
'Search'.

Test plan :
1)
1.1) Set system preferences :
  OpacAddMastheadLibraryPulldown to 'Add'
  SearchMyLibraryFirst to 'Don't limit'
1.2) Go to OPAC main page
1.3) You don't see 'Search' anymore
1.4) You see in submit button an icon
1.5) Move mouse over submit button to see tooltip text 'Search'
2)
2.1) Set system preferences :
  OpacAddMastheadLibraryPulldown to 'Don't add'
  SearchMyLibraryFirst to 'Limit'
2.2) Go to OPAC main page
2.3) Log in
2.4) You don't see text 'Search (in <library name>) only'
2.5) You see a question mark icon
2.6) Move mouse over submit button to see tooltip text 'Search (in <library name>) only'

Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi>
---
 .../bootstrap/en/includes/masthead.inc        | 25 ++++++++++---------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
index c2cf93a090..48b98c63ae 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
@@ -163,13 +163,13 @@
                                     <form name="searchform" method="get" action="/cgi-bin/koha/opac-search.pl" id="searchform">
                                         <div class="form-row align-items-center">
                                             <div class="col-sm-auto order-1 order-sm-1">
-                                                <label for="masthead_search"> Search
-                                                    [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %]
-                                                        [% IF ( mylibraryfirst ) %]
-                                                            (in [% Branches.GetName( mylibraryfirst ) | html %] only)
-                                                        [% END %]
+                                                [% UNLESS ( Koha.Preference( 'OpacAddMastheadLibraryPulldown' ) == 1 ) %]
+                                                    [% IF ( mylibraryfirst ) %]
+                                                        <span title="Search in [% Branches.GetName( mylibraryfirst ) | html %] only">
+                                                            <i class="fa fa-question-circle-o"></i>
+                                                        </span>
                                                     [% END %]
-                                                </label>
+                                                [% END %]
                                             </div>
                                             <div class="col-sm-auto order-2 order-sm-2">
                                                 <select name="idx" id="masthead_search" class="form-control">
@@ -261,9 +261,6 @@
                                                         [% END # / BranchCategoriesLoop %]
                                                     </select> <!-- /#select_library -->
                                                 </div> <!-- /.col-sm-auto -->
-                                                <div class="col-sm-auto order-5">
-                                                    <button type="submit" id="searchsubmit" class="btn btn-primary">Go</button>
-                                                </div>
                                             [% ELSE %]
                                                 [% IF ( opac_limit_override ) %]
                                                     [% IF ( opac_search_limit ) %]
@@ -278,10 +275,14 @@
                                                         <input name="limit" value="branch:[% mylibraryfirst | html %]" type="hidden" />
                                                     [% END %]
                                                 [% END # / opac_limit_override %]
-                                                <div class="order-5 col-sm-auto">
-                                                    <button type="submit" id="searchsubmit" class="btn btn-primary">Go</button>
-                                                </div>
                                             [% END # / OpacAddMastheadLibraryPulldown %]
+
+                                            <div class="order-5 col-sm-auto">
+                                                <button type="submit" id="searchsubmit" class="btn btn-primary" title="Search">
+                                                    <i class="fa fa-search"></i>
+                                                </button>
+                                            </div>
+
                                         </div> <!-- /.form-row -->
                                         <input type="hidden" name="weight_search" value="1">
                                     </form>
-- 
2.25.1