Bugzilla – Attachment 128987 Details for
Bug 29786
Holds to pull report shows incorrect item for item level holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29786: Unit tests
Bug-29786-Unit-tests.patch (text/plain), 2.49 KB, created by
Nick Clemens
on 2022-01-04 13:42:39 UTC
(
hide
)
Description:
Bug 29786: Unit tests
Filename:
MIME Type:
Creator:
Nick Clemens
Created:
2022-01-04 13:42:39 UTC
Size:
2.49 KB
patch
obsolete
>From c8c3fb2bf542b55b30b7f445ace0f4eea9ffffca Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 4 Jan 2022 13:33:07 +0000 >Subject: [PATCH] Bug 29786: Unit tests > >I add a new test for the case of an item level hold, and additionally >adjust later tests to use a title level hold. > >I also fix a typo where the comment says item 1 when it means item 2 >--- > t/db_dependent/Koha/Holds.t | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > >diff --git a/t/db_dependent/Koha/Holds.t b/t/db_dependent/Koha/Holds.t >index 51c3383277..adbb588f86 100755 >--- a/t/db_dependent/Koha/Holds.t >+++ b/t/db_dependent/Koha/Holds.t >@@ -410,7 +410,7 @@ subtest 'Desks' => sub { > }; > > subtest 'get_items_that_can_fill' => sub { >- plan tests => 2; >+ plan tests => 3; > > my $biblio = $builder->build_sample_biblio; > my $itype_1 = $builder->build_object({ class => 'Koha::ItemTypes' }); # For 1, 2, 3, 4 >@@ -442,12 +442,16 @@ subtest 'get_items_that_can_fill' => sub { > } > ); > >+ my $holds = Koha::Holds->search({ reserve_id => $reserve_id_1 }); >+ my $items = $holds->get_items_that_can_fill; >+ is_deeply( [ map { $_->itemnumber } $items->as_list ], [ $item_1->itemnumber ], 'Item level hold can only be filled by the specific item'); >+ > my $reserve_id_2 = C4::Reserves::AddReserve( > { > borrowernumber => $patron_2->borrowernumber, > biblionumber => $biblio->biblionumber, > priority => 2, >- itemnumber => $item_1->itemnumber, >+ branchcode => $item_1->homebranch, > } > ); > >@@ -476,13 +480,13 @@ subtest 'get_items_that_can_fill' => sub { > } > )->store; > >- my $holds = Koha::Holds->search( >+ $holds = Koha::Holds->search( > { > reserve_id => [ $reserve_id_1, $reserve_id_2, $waiting_reserve_id, ] > } > ); > >- my $items = $holds->get_items_that_can_fill; >+ $items = $holds->get_items_that_can_fill; > is_deeply( [ map { $_->itemnumber } $items->as_list ], > [ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 2 and 5 are available for filling the hold' ); > >@@ -496,7 +500,7 @@ subtest 'get_items_that_can_fill' => sub { > )->store; > $items = $holds->get_items_that_can_fill; > is_deeply( [ map { $_->itemnumber } $items->as_list ], >- [ $item_2->itemnumber ], 'Only item 1 is available for filling the hold' ); >+ [ $item_2->itemnumber ], 'Only item 2 is available for filling the hold' ); > > }; > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29786
:
128987
|
128988
|
128989
|
128990
|
129139
|
129140