View | Details | Raw Unified | Return to bug 29804
Collapse All | Expand All

(-)a/t/db_dependent/Koha/Hold.t (-2 / +47 lines)
Lines 147-153 subtest 'set_pickup_location() tests' => sub { Link Here
147
147
148
subtest 'is_pickup_location_valid() tests' => sub {
148
subtest 'is_pickup_location_valid() tests' => sub {
149
149
150
    plan tests => 4;
150
    plan tests => 5;
151
151
152
    $schema->storage->txn_begin;
152
    $schema->storage->txn_begin;
153
153
Lines 200-204 subtest 'is_pickup_location_valid() tests' => sub { Link Here
200
    ok( !$item_hold->is_pickup_location_valid({ library_id => $library_1->branchcode }), 'Pickup location invalid');
200
    ok( !$item_hold->is_pickup_location_valid({ library_id => $library_1->branchcode }), 'Pickup location invalid');
201
    ok( $item_hold->is_pickup_location_valid({ library_id => $library_2->id }), 'Pickup location valid' );
201
    ok( $item_hold->is_pickup_location_valid({ library_id => $library_2->id }), 'Pickup location valid' );
202
202
203
    subtest 'pickup_locations() returning ->empty' => sub {
204
205
        plan tests => 2;
206
207
        $schema->storage->txn_begin;
208
209
        my $library = $builder->build_object({ class => 'Koha::Libraries' });
210
211
        my $mock_item = Test::MockModule->new('Koha::Item');
212
        $mock_item->mock( 'pickup_locations', sub { return Koha::Libraries->new->empty; } );
213
214
        my $mock_biblio = Test::MockModule->new('Koha::Biblio');
215
        $mock_biblio->mock( 'pickup_locations', sub { return Koha::Libraries->new->empty; } );
216
217
        my $item   = $builder->build_sample_item();
218
        my $biblio = $item->biblio;
219
220
        # Test biblio-level holds
221
        my $biblio_hold = $builder->build_object(
222
            {
223
                class => "Koha::Holds",
224
                value => {
225
                    biblionumber => $biblio->biblionumber,
226
                    itemnumber   => undef,
227
                }
228
            }
229
        );
230
231
        ok( !$biblio_hold->is_pickup_location_valid({ library_id => $library->branchcode }), 'Pickup location invalid');
232
233
        # Test item-level holds
234
        my $item_hold = $builder->build_object(
235
            {
236
                class => "Koha::Holds",
237
                value => {
238
                    biblionumber => $biblio->biblionumber,
239
                    itemnumber   => $item->itemnumber,
240
                }
241
            }
242
        );
243
244
        ok( !$item_hold->is_pickup_location_valid({ library_id => $library->branchcode }), 'Pickup location invalid');
245
246
        $schema->storage->txn_rollback;
247
    };
248
203
    $schema->storage->txn_rollback;
249
    $schema->storage->txn_rollback;
204
};
250
};
205
- 

Return to bug 29804