From e1c7a51a5ea648734ba8b8ffef729124eab17fb5 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 10 Jan 2022 10:15:35 +0100 Subject: [PATCH] Bug 29828: Prevent additional content to be created without default When creating or editing an additional content, the form is submitted if only the title of the 'default' tab is filled in. We should submit the form only if both title and content exist. Test plan: Create a new content using text editor (codemirror) Confirm that the form is submitted only if title and content from the default tab are not empty Try again with wysiwyg (tinymce) --- .../prog/en/modules/tools/additional-contents.tt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt index 1c3ac717cc2..cfa0d00a911 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt @@ -560,6 +560,18 @@ alert(__("Please specify a title for 'Default'")); return false; } + else { + [% UNLESS wysiwyg %] + let content = $('#content_default').siblings(".CodeMirror")[0].CodeMirror.getValue(); + [% ELSE %] + let content = tinyMCE.get('content_default').getContent(); + [% END %] + + if ( ! content.length > 0 ) { + alert(__("Please specify a content for 'Default'")); + return false; + } + } form.submit(); } -- 2.25.1