@@ -, +, @@ | grep '@' --- C4/Items.pm | 2 +- Koha/ItemType.pm | 2 +- reports/guided_reports.pl | 4 ++-- t/db_dependent/Acquisition.t | 10 +++++----- t/db_dependent/Koha/Acquisition/Basket.t | 2 +- t/db_dependent/Patron/HouseboundRoles.t | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) --- a/C4/Items.pm +++ a/C4/Items.pm @@ -636,7 +636,7 @@ sub GetItemsForInventory { '+select' => [ 'marc_subfield_structures.kohafield', 'marc_subfield_structures.frameworkcode', 'me.authorised_value', 'me.lib' ], '+as' => [ 'kohafield', 'frameworkcode', 'authorised_value', 'lib' ], } - ); + )->as_list; my $avmapping = { map { $_->get_column('kohafield') . ',' . $_->get_column('frameworkcode') . ',' . $_->get_column('authorised_value') => $_->get_column('lib') } @avs }; --- a/Koha/ItemType.pm +++ a/Koha/ItemType.pm @@ -80,7 +80,7 @@ sub translated_descriptions { { entity => 'itemtypes', code => $self->itemtype, } - ); + )->as_list; return [ map { { lang => $_->lang, --- a/reports/guided_reports.pl +++ a/reports/guided_reports.pl @@ -749,7 +749,7 @@ elsif ($phase eq 'Run this report'){ } } elsif ( $authorised_value eq "biblio_framework" ) { - my @frameworks = Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); + my @frameworks = Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] })->as_list; my $default_source = ''; push @authorised_values,$default_source; $authorised_lib{$default_source} = 'Default'; @@ -769,7 +769,7 @@ elsif ($phase eq 'Run this report'){ } } elsif ( $authorised_value eq "categorycode" ) { - my @patron_categories = Koha::Patron::Categories->search({}, { order_by => ['description']}); + my @patron_categories = Koha::Patron::Categories->search({}, { order_by => ['description']})->as_list; %authorised_lib = map { $_->categorycode => $_->description } @patron_categories; push @authorised_values, $_->categorycode for @patron_categories; } --- a/t/db_dependent/Acquisition.t +++ a/t/db_dependent/Acquisition.t @@ -911,12 +911,12 @@ subtest 'Acquisition logging' => sub { Koha::ActionLogs->delete; my $basketno = NewBasket( $booksellerid, 1 ); - my @create_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'ADD_BASKET', object => $basketno }); + my @create_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'ADD_BASKET', object => $basketno })->as_list; is (scalar @create_logs, 1, 'Basket creation is logged'); Koha::ActionLogs->delete; C4::Acquisition::ReopenBasket($basketno); - my @reopen_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'REOPEN_BASKET', object => $basketno }); + my @reopen_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'REOPEN_BASKET', object => $basketno })->as_list; is (scalar @reopen_logs, 1, 'Basket reopen is logged'); Koha::ActionLogs->delete; @@ -924,17 +924,17 @@ subtest 'Acquisition logging' => sub { basketno => $basketno, booksellerid => $booksellerid }); - my @mod_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'MODIFY_BASKET', object => $basketno }); + my @mod_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'MODIFY_BASKET', object => $basketno })->as_list; is (scalar @mod_logs, 1, 'Basket modify is logged'); Koha::ActionLogs->delete; C4::Acquisition::ModBasketHeader($basketno,"Test","","","",$booksellerid); - my @mod_header_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'MODIFY_BASKET_HEADER', object => $basketno }); + my @mod_header_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'MODIFY_BASKET_HEADER', object => $basketno })->as_list; is (scalar @mod_header_logs, 1, 'Basket header modify is logged'); Koha::ActionLogs->delete; C4::Acquisition::ModBasketUsers($basketno,(1)); - my @mod_users_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'MODIFY_BASKET_USERS', object => $basketno }); + my @mod_users_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'MODIFY_BASKET_USERS', object => $basketno })->as_list; is (scalar @mod_users_logs, 1, 'Basket users modify is logged'); t::lib::Mocks::mock_preference('AcquisitionLog', 0); --- a/t/db_dependent/Koha/Acquisition/Basket.t +++ a/t/db_dependent/Koha/Acquisition/Basket.t @@ -425,7 +425,7 @@ subtest 'close() tests' => sub { 'Koha::Exceptions::Acquisition::Basket::AlreadyClosed', 'Trying to close an already closed basket throws an exception'; - my @close_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'CLOSE_BASKET', object => $basket->id }); + my @close_logs = Koha::ActionLogs->search({ module =>'ACQUISITIONS', action => 'CLOSE_BASKET', object => $basket->id })->as_list; is (scalar @close_logs, 1, 'Basket closure is logged'); $schema->storage->txn_rollback; --- a/t/db_dependent/Patron/HouseboundRoles.t +++ a/t/db_dependent/Patron/HouseboundRoles.t @@ -42,7 +42,7 @@ is( ); my @roles = Koha::Patron::HouseboundRoles - ->search({ borrowernumber_id => $role->{borrowernumber_id} }); + ->search({ borrowernumber_id => $role->{borrowernumber_id} })->as_list; my $found_role = shift @roles; is( $found_role->borrowernumber_id, --