From 5f056152d06829fe00c597933f5778743d7fb7f7 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 11 Jan 2022 14:31:27 +0000 Subject: [PATCH] Bug 29759: (QA follow-up) Remove abs from the test Content-Type: text/plain; charset=utf-8 Obviously abs has two sides, and we could allow wrong results. We can be more precise here. Trivial exercise. Signed-off-by: Marcel de Rooy --- t/db_dependent/Koha/ArticleRequest.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/ArticleRequest.t b/t/db_dependent/Koha/ArticleRequest.t index b7bceb382e..9a5501bff2 100755 --- a/t/db_dependent/Koha/ArticleRequest.t +++ b/t/db_dependent/Koha/ArticleRequest.t @@ -199,7 +199,7 @@ subtest 'cancel() tests' => sub { is( $ar->cancellation_reason, $reason, 'Cancellation reason stored correctly' ); is( $ar->notes, $notes, 'Notes stored correctly' ); - is( abs $patron->account->balance, $payed_amount, 'The patron has been refunded the right value' ); + is( $patron->account->balance, -$payed_amount, 'The patron has a credit balance' ); $schema->storage->txn_rollback; }; -- 2.20.1