From a8f3d22277ce126a9abd94c488cf2bdde74b1c64 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 10 Jan 2022 14:02:49 +0100
Subject: [PATCH] Bug 29840: Deal with non-existing biblionumber in
 opac-reserve

We should not explode if the biblionumber passed in not in DB.

Test plan:
Hit /cgi-bin/koha/opac-reserve.pl?biblionumber=42424
and notice the error message.

Without this patch you got
Can't call method "holds" on an undefined value at
/kohadevbox/koha/opac/opac-reserve.pl line 172

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
---
 opac/opac-reserve.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
index a7391e2327..9ed1021054 100755
--- a/opac/opac-reserve.pl
+++ b/opac/opac-reserve.pl
@@ -168,6 +168,8 @@ foreach my $biblioNumber (@biblionumbers) {
 
     # Compute the priority rank.
     my $biblio = Koha::Biblios->find( $biblioNumber );
+    next unless $biblio;
+
     $biblioData->{object} = $biblio;
     my $holds = $biblio->holds;
     my $rank = $holds->count;
-- 
2.20.1