Bugzilla – Attachment 129338 Details for
Bug 29544
A patron can set everybody's checkout notes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[OPTIONAL] Bug 29544: (QA follow-up) Simplify code
OPTIONAL-Bug-29544-QA-follow-up-Simplify-code.patch (text/plain), 989 bytes, created by
Tomás Cohen Arazi
on 2022-01-12 12:47:18 UTC
(
hide
)
Description:
[OPTIONAL] Bug 29544: (QA follow-up) Simplify code
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2022-01-12 12:47:18 UTC
Size:
989 bytes
patch
obsolete
>From 8b71e22362c64a1b5ac0a285374ebdb900869b39 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 12 Jan 2022 09:43:48 -0300 >Subject: [PATCH] [OPTIONAL] Bug 29544: (QA follow-up) Simplify code > >I think this is a better approach for the same thing. Posting it just in >case it helps. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > opac/opac-issue-note.pl | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/opac/opac-issue-note.pl b/opac/opac-issue-note.pl >index 5cfb7aef15..b59e838b06 100755 >--- a/opac/opac-issue-note.pl >+++ b/opac/opac-issue-note.pl >@@ -48,10 +48,9 @@ $template->param( > ); > > my $issue_id = $query->param('issue_id'); >-my $issue = Koha::Checkouts->find( $issue_id ); >+my $issue = $patron->checkouts->find( $issue_id ); > >- >-if ( !$issue || $issue->borrowernumber != $borrowernumber ) { >+unless ( $issue ) { > # exit early > print $query->redirect("/cgi-bin/koha/opac-user.pl"); > exit; >-- >2.32.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29544
:
127930
|
128148
|
128946
|
128947
|
129336
|
129337
| 129338