From bdcb0e9200dd2f4a371fcee23622210ac8038bbd Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Fri, 14 Jan 2022 15:17:56 +0100 Subject: [PATCH] Bug 29884: Run missing test in api/v1/patrons.t compare is not calling is() or ok(), it's caller job to do it. Test plan: prove t/db_dependent/api/v1/patrons.t should still return green --- t/db_dependent/api/v1/patrons.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/api/v1/patrons.t b/t/db_dependent/api/v1/patrons.t index b7e65dc91cd..dc8e56a00bd 100755 --- a/t/db_dependent/api/v1/patrons.t +++ b/t/db_dependent/api/v1/patrons.t @@ -545,7 +545,7 @@ subtest 'update() tests' => sub { $schema->storage->txn_rollback; subtest 'librarian access tests' => sub { - plan tests => 44; + plan tests => 45; $schema->storage->txn_begin; @@ -659,7 +659,7 @@ subtest 'update() tests' => sub { my $updated_on_got = delete $got->{updated_on}; my $updated_on_expected = delete $newpatron->{updated_on}; is_deeply($got, $newpatron, 'Returned patron from update matches expected'); - t::lib::Dates::compare( $updated_on_got, $updated_on_expected, 'updated_on values matched' ); + is( t::lib::Dates::compare( $updated_on_got, $updated_on_expected ), 0, 'updated_on values matched' ); is(Koha::Patrons->find( $patron_2->id )->cardnumber, $newpatron->{ cardnumber }, 'Patron is really updated!'); -- 2.25.1