Bugzilla – Attachment 129580 Details for
Bug 29873
2FA: Generate QR code without exposing secret via HTTP GET
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29873: Adjust QR image size
Bug-29873-Adjust-QR-image-size.patch (text/plain), 1.16 KB, created by
Marcel de Rooy
on 2022-01-18 15:35:17 UTC
(
hide
)
Description:
Bug 29873: Adjust QR image size
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2022-01-18 15:35:17 UTC
Size:
1.16 KB
patch
obsolete
>From 31dccf52dea4e5a8969122bd41a81e414949ed88 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 18 Jan 2022 15:11:19 +0000 >Subject: [PATCH] Bug 29873: Adjust QR image size >Content-Type: text/plain; charset=utf-8 > >Size parameter 8 results in too big images. >Size parameter 4 seems fine. Although I have seen variations >in the number of pixels from about 116x116 to 180x180. >The documentation is a bit obsure. > >Test plan: >Register again with smaller QR code and logout/login. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Auth/TwoFactorAuth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/Auth/TwoFactorAuth.pm b/Koha/Auth/TwoFactorAuth.pm >index 8d61d91f85..2dccdbb608 100644 >--- a/Koha/Auth/TwoFactorAuth.pm >+++ b/Koha/Auth/TwoFactorAuth.pm >@@ -78,7 +78,7 @@ sub qr_dataurl { > my $otpauth = $self->qr_code( undef, undef, undef, 1); > # no need to pass secret, key and issuer again > my $qrcode = Imager::QRCode->new({ >- size => 8, # 200 x 200 >+ size => 4, > margin => 2, > version => 1, > level => 'M', >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29873
:
129402
|
129576
|
129577
|
129578
|
129579
|
129580
|
129581
|
129605
|
133216
|
133217
|
133558
|
133559
|
133659
|
133660