Bugzilla – Attachment 129874 Details for
Bug 29952
Filter Paid Transactions Broken on Transactions tab in Staff
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29952: Replace obsolete DataTable column filter function
Bug-29952-Replace-obsolete-DataTable-column-filter.patch (text/plain), 1.95 KB, created by
Owen Leonard
on 2022-01-27 12:40:02 UTC
(
hide
)
Description:
Bug 29952: Replace obsolete DataTable column filter function
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2022-01-27 12:40:02 UTC
Size:
1.95 KB
patch
obsolete
>From 04cc6a285d610ec658ce7d590dee2474e051ac3a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 27 Jan 2022 11:50:28 +0000 >Subject: [PATCH] Bug 29952: Replace obsolete DataTable column filter function > >The "Filter paid transactions" link on the Accounting -> Transactions >page is broken because it uses an obsolete DataTables function for >filtering. This patch updates it to use the current syntax, available in >DataTables since version 1.10. > >To test, apply the patch and locate a patron in the staff interface who >has multiple fines, some paid. > >- View the patron's "Accounting" page and click the "Transactions" tab. >- Click the "Filter paid transactions" link. The table should be > filtered so that only transactions with an outstanding amount > zero > are shown. >- The filter link should change to read "Show all transactions." >- Clicking "Show all transactions" should clear the filter. >- Test with one or more columns hidden using the "Columns" control. > Filtering should still work correctly with columns hidden. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index 4b0452b2db..2fd9240414 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -349,7 +349,7 @@ > var filteredValue = '^((?!0.00).*)$'; //Filter not matching 0.00 http://stackoverflow.com/a/406408 > $(this).html('<i class="fa fa-filter"></i> '+txtInactivefilter); > } >- table_account_fines.fnFilter(filteredValue, 10, true, false); >+ table_account_fines.DataTable().columns( 13 ).search( filteredValue, true, false ).draw(); > $(this).toggleClass('filtered'); > }); > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29952
:
129873
|
129874
|
130041
|
130160
|
130333