From 4f913e35246eb1fec408769047a1a58a41d27672 Mon Sep 17 00:00:00 2001 From: Owen Leonard <oleonard@myacpl.org> Date: Tue, 30 Nov 2021 15:06:05 +0000 Subject: [PATCH] Bug 29960: Remove Modernizr dependency in the OPAC This patch refactors the code around JavaScript-driven responsive behavior in the OPAC. The use of Modernizr dropped and the dependency removed. This patch also adds a missing listing for Enquire.js licensing on the "About" page. To test, apply the patch and perform a catalog search in the OPAC. - Narrow your browser window until its width falls below 609 pixels (Using your browser's Responsive Design Mode is helpful for this, e.g. https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode) - The window should automatically scroll to the "main content" area, in this case the section headed by "Your search returned..." - Change your browser window's width until it falls below 768 pixels. - Scroll to the bottom of the search results where you should find the "Refine your search" facets box collapsed. - As you increase your browser width above 768 pixels the facets box should expand. --- .../intranet-tmpl/prog/en/modules/about.tt | 3 + .../bootstrap/en/includes/doc-head-close.inc | 1 - .../bootstrap/en/includes/opac-bottom.inc | 23 +---- .../bootstrap/en/modules/sci/sci-main.tt | 1 - .../bootstrap/en/modules/sco/help.tt | 1 - .../bootstrap/en/modules/sco/sco-main.tt | 1 - koha-tmpl/opac-tmpl/bootstrap/js/global.js | 85 +++++++++++++++++-- koha-tmpl/opac-tmpl/bootstrap/js/script.js | 71 ---------------- .../opac-tmpl/bootstrap/lib/modernizr.min.js | 4 - 9 files changed, 85 insertions(+), 105 deletions(-) delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/js/script.js delete mode 100644 koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt index 3b5a3ae6b8..01b7d64efd 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt @@ -815,6 +815,9 @@ <h2>Chocolat.js</h2> <p><a href="http://chocolat.insipi.de">Chocolat.js</a> licensed under the <a href="https://github.com/nicolas-t/Chocolat/blob/master/LICENSE">GPL v3 license</a>.</p> + <h2>Enquire.js</h2> + <p><a href="https://wicky.nillia.ms/enquire.js">Enquire.js</a> licensed under the <a href="https://github.com/WickyNilliams/enquire.js/blob/master/LICENSE">MIT license</a>.</p> + </div> <div id="translations"> diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc index e0963ca5d3..8e9ec50ec6 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc @@ -70,7 +70,6 @@ [% Asset.js('js/Gettext.js') | $raw %] [% Asset.js('js/i18n.js') | $raw %] -[% Asset.js("lib/modernizr.min.js") | $raw %] [% Asset.css("lib/font-awesome/css/font-awesome.min.css") | $raw %] [% PROCESS 'html_helpers.inc' %] [% KohaPlugins.get_plugins_opac_head | $raw %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index e4aaccf54a..5398bf3fcb 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -127,28 +127,13 @@ $.widget.bridge('uitooltip', $.ui.tooltip); </script> [% Asset.js("lib/bootstrap/js/bootstrap.bundle.min.js") | $raw %] [% Asset.js("lib/fontfaceobserver.min.js") | $raw %] +[% Asset.js("lib/enquire.min.js") | $raw %] [% Asset.js("js/global.js") | $raw %] -<script> - Modernizr.load([ - // Test need for polyfill - { - test: window.matchMedia, - nope: "[% Asset.url('lib/media.match.min.js') | $raw %]" - }, - // and then load enquire - "[% Asset.url('lib/enquire.min.js') | $raw %]", - "[% Asset.url('js/script.js') | $raw %]", - ]); - - // Fix for datepicker in a modal - $.fn.modal.Constructor.prototype.enforceFocus = function () {}; -</script> [% IF ( OPACAmazonCoverImages || SyndeticsCoverImages ) %] -<script> + <script> var NO_AMAZON_IMAGE = _("No cover image available"); - -</script> -[% Asset.js("js/amazonimages.js") | $raw %] + </script> + [% Asset.js("js/amazonimages.js") | $raw %] [% END %] <script> diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt index 06c9752456..67deea4c8c 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt @@ -46,7 +46,6 @@ <script> function _(s) { return s } // dummy function for gettext </script> -[% Asset.js("lib/modernizr.min.js") | $raw %] </head> <body id="sci_main" class="sci" onload="dofocus();" onunload="mungeHistory();"> [% INCLUDE 'masthead-sci.inc' %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt index 5d5eefd2ee..90614bde2d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt @@ -15,7 +15,6 @@ <script> function _(s) { return s } // dummy function for gettext </script> -[% Asset.js("lib/modernizr.min.js") | $raw %] </head> <body id="sco_help" class="sco"> [% INCLUDE 'masthead-sco.inc' %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt index bddfa7e919..5d6fd4161a 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt @@ -33,7 +33,6 @@ [% END %] [% Asset.js('js/Gettext.js') | $raw %] [% Asset.js('js/i18n.js') | $raw %] -[% Asset.js("lib/modernizr.min.js") | $raw %] </head> <body id="sco_main" class="sco" onload="dofocus();" onunload="mungeHistory();"> [% INCLUDE 'masthead-sco.inc' %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/global.js b/koha-tmpl/opac-tmpl/bootstrap/js/global.js index 27f2874502..171dfd2bd0 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/js/global.js +++ b/koha-tmpl/opac-tmpl/bootstrap/js/global.js @@ -1,3 +1,4 @@ +/* global enquire readCookie updateBasket delCookie */ (function( w ){ // if the class is already set, the font has already been loaded if( w.document.documentElement.className.indexOf( "fonts-loaded" ) > -1 ){ @@ -151,13 +152,83 @@ function confirmModal(message, title, yes_label, no_label, callback) { }); })(jQuery); -$("#scrolltocontent").click(function() { - var content = $(".maincontent"); - if (content.length > 0) { - $('html,body').animate({ +enquire.register("screen and (max-width:608px)", { + match : function() { + if($("body.scrollto").length > 0){ + window.scrollTo( 0, $(".maincontent").offset().top ); + } + } +}); + +enquire.register("screen and (min-width:768px)", { + match : function() { + facetMenu( "show" ); + }, + unmatch : function() { + facetMenu( "hide" ); + } +}); + +function facetMenu( action ){ + if( action == "show" ){ + $(".menu-collapse-toggle").off("click", facetHandler ); + $(".menu-collapse").show(); + } else { + $(".menu-collapse-toggle").on("click", facetHandler ).removeClass("menu-open"); + $(".menu-collapse").hide(); + } +} + +var facetHandler = function(e){ + e.preventDefault(); + $(this).toggleClass("menu-open"); + $(".menu-collapse").toggle(); +}; + +$(document).ready(function(){ + $("html").removeClass("no-js").addClass("js"); + $(".close").click(function(){ + window.close(); + }); + $(".focus").focus(); + $(".js-show").show(); + $(".js-hide").hide(); + + if( $(window).width() < 768 ){ + facetMenu("hide"); + } + + // clear the basket when user logs out + $("#logout").click(function(){ + var nameCookie = "bib_list"; + var valCookie = readCookie(nameCookie); + if (valCookie) { // basket has contents + updateBasket(0,null); + delCookie(nameCookie); + return true; + } else { + return true; + } + }); + + $(".loginModal-trigger").on("click",function(e){ + e.preventDefault(); + $("#loginModal").modal("show"); + }); + $("#loginModal").on("shown.bs.modal", function(){ + $("#muserid").focus(); + }); + + $("#scrolltocontent").click(function() { + var content = $(".maincontent"); + if (content.length > 0) { + $('html,body').animate({ scrollTop: content.first().offset().top }, - 'slow'); - content.first().find(':focusable').eq(0).focus(); - } + 'slow'); + content.first().find(':focusable').eq(0).focus(); + } + }); }); + +$.fn.modal.Constructor.prototype.enforceFocus = function () {}; diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/script.js b/koha-tmpl/opac-tmpl/bootstrap/js/script.js deleted file mode 100644 index 512f4609fb..0000000000 --- a/koha-tmpl/opac-tmpl/bootstrap/js/script.js +++ /dev/null @@ -1,71 +0,0 @@ -/* global enquire readCookie updateBasket delCookie */ -enquire.register("screen and (max-width:608px)", { - match : function() { - if($("body.scrollto").length > 0){ - $("body.scrollto").animate({ - scrollTop: $(".maincontent").offset().top - }, 10); - } - }, - unmatch : function() { - } -}); - -enquire.register("screen and (min-width:768px)", { - match : function() { - facetMenu( "show" ); - }, - unmatch : function() { - facetMenu( "hide" ); - } -}); - -function facetMenu( action ){ - if( action == "show" ){ - $(".menu-collapse-toggle").unbind("click", facetHandler ) - $(".menu-collapse").show(); - } else { - $(".menu-collapse-toggle").bind("click", facetHandler ).removeClass("menu-open"); - $(".menu-collapse").hide(); - } -} - -var facetHandler = function(e){ - e.preventDefault(); - $(this).toggleClass("menu-open"); - $(".menu-collapse").toggle(); -}; - -$(document).ready(function(){ - $(".close").click(function(){ - window.close(); - }); - $(".focus").focus(); - $(".js-show").show(); - $(".js-hide").hide(); - - if( $(window).width() < 768 ){ - facetMenu("hide"); - } - - // clear the basket when user logs out - $("#logout").click(function(){ - var nameCookie = "bib_list"; - var valCookie = readCookie(nameCookie); - if (valCookie) { // basket has contents - updateBasket(0,null); - delCookie(nameCookie); - return true; - } else { - return true; - } - }); - - $(".loginModal-trigger").on("click",function(e){ - e.preventDefault(); - $("#loginModal").modal("show"); - }); - $("#loginModal").on("shown.bs.modal", function(){ - $("#muserid").focus(); - }); -}); diff --git a/koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js b/koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js deleted file mode 100644 index c5c71ef635..0000000000 --- a/koha-tmpl/opac-tmpl/bootstrap/lib/modernizr.min.js +++ /dev/null @@ -1,4 +0,0 @@ -/* Modernizr 2.6.2 (Custom Build) | MIT & BSD - * Build: http://modernizr.com/download/#-shiv-cssclasses-load - */ -;window.Modernizr=function(a,b,c){function u(a){j.cssText=a}function v(a,b){return u(prefixes.join(a+";")+(b||""))}function w(a,b){return typeof a===b}function x(a,b){return!!~(""+a).indexOf(b)}function y(a,b,d){for(var e in a){var f=b[a[e]];if(f!==c)return d===!1?a[e]:w(f,"function")?f.bind(d||b):f}return!1}var d="2.6.2",e={},f=!0,g=b.documentElement,h="modernizr",i=b.createElement(h),j=i.style,k,l={}.toString,m={},n={},o={},p=[],q=p.slice,r,s={}.hasOwnProperty,t;!w(s,"undefined")&&!w(s.call,"undefined")?t=function(a,b){return s.call(a,b)}:t=function(a,b){return b in a&&w(a.constructor.prototype[b],"undefined")},Function.prototype.bind||(Function.prototype.bind=function(b){var c=this;if(typeof c!="function")throw new TypeError;var d=q.call(arguments,1),e=function(){if(this instanceof e){var a=function(){};a.prototype=c.prototype;var f=new a,g=c.apply(f,d.concat(q.call(arguments)));return Object(g)===g?g:f}return c.apply(b,d.concat(q.call(arguments)))};return e});for(var z in m)t(m,z)&&(r=z.toLowerCase(),e[r]=m[z](),p.push((e[r]?"":"no-")+r));return e.addTest=function(a,b){if(typeof a=="object")for(var d in a)t(a,d)&&e.addTest(d,a[d]);else{a=a.toLowerCase();if(e[a]!==c)return e;b=typeof b=="function"?b():b,typeof f!="undefined"&&f&&(g.className+=" "+(b?"":"no-")+a),e[a]=b}return e},u(""),i=k=null,function(a,b){function k(a,b){var c=a.createElement("p"),d=a.getElementsByTagName("head")[0]||a.documentElement;return c.innerHTML="x<style>"+b+"</style>",d.insertBefore(c.lastChild,d.firstChild)}function l(){var a=r.elements;return typeof a=="string"?a.split(" "):a}function m(a){var b=i[a[g]];return b||(b={},h++,a[g]=h,i[h]=b),b}function n(a,c,f){c||(c=b);if(j)return c.createElement(a);f||(f=m(c));var g;return f.cache[a]?g=f.cache[a].cloneNode():e.test(a)?g=(f.cache[a]=f.createElem(a)).cloneNode():g=f.createElem(a),g.canHaveChildren&&!d.test(a)?f.frag.appendChild(g):g}function o(a,c){a||(a=b);if(j)return a.createDocumentFragment();c=c||m(a);var d=c.frag.cloneNode(),e=0,f=l(),g=f.length;for(;e<g;e++)d.createElement(f[e]);return d}function p(a,b){b.cache||(b.cache={},b.createElem=a.createElement,b.createFrag=a.createDocumentFragment,b.frag=b.createFrag()),a.createElement=function(c){return r.shivMethods?n(c,a,b):b.createElem(c)},a.createDocumentFragment=Function("h,f","return function(){var n=f.cloneNode(),c=n.createElement;h.shivMethods&&("+l().join().replace(/\w+/g,function(a){return b.createElem(a),b.frag.createElement(a),'c("'+a+'")'})+");return n}")(r,b.frag)}function q(a){a||(a=b);var c=m(a);return r.shivCSS&&!f&&!c.hasCSS&&(c.hasCSS=!!k(a,"article,aside,figcaption,figure,footer,header,hgroup,nav,section{display:block}mark{background:#FF0;color:#000}")),j||p(a,c),a}var c=a.html5||{},d=/^<|^(?:button|map|select|textarea|object|iframe|option|optgroup)$/i,e=/^(?:a|b|code|div|fieldset|h1|h2|h3|h4|h5|h6|i|label|li|ol|p|q|span|strong|style|table|tbody|td|th|tr|ul)$/i,f,g="_html5shiv",h=0,i={},j;(function(){try{var a=b.createElement("a");a.innerHTML="<xyz></xyz>",f="hidden"in a,j=a.childNodes.length==1||function(){b.createElement("a");var a=b.createDocumentFragment();return typeof a.cloneNode=="undefined"||typeof a.createDocumentFragment=="undefined"||typeof a.createElement=="undefined"}()}catch(c){f=!0,j=!0}})();var r={elements:c.elements||"abbr article aside audio bdi canvas data datalist details figcaption figure footer header hgroup mark meter nav output progress section summary time video",shivCSS:c.shivCSS!==!1,supportsUnknownElements:j,shivMethods:c.shivMethods!==!1,type:"default",shivDocument:q,createElement:n,createDocumentFragment:o};a.html5=r,q(b)}(this,b),e._version=d,g.className=g.className.replace(/(^|\s)no-js(\s|$)/,"$1$2")+(f?" js "+p.join(" "):""),e}(this,this.document),function(a,b,c){function d(a){return"[object Function]"==o.call(a)}function e(a){return"string"==typeof a}function f(){}function g(a){return!a||"loaded"==a||"complete"==a||"uninitialized"==a}function h(){var a=p.shift();q=1,a?a.t?m(function(){("c"==a.t?B.injectCss:B.injectJs)(a.s,0,a.a,a.x,a.e,1)},0):(a(),h()):q=0}function i(a,c,d,e,f,i,j){function k(b){if(!o&&g(l.readyState)&&(u.r=o=1,!q&&h(),l.onload=l.onreadystatechange=null,b)){"img"!=a&&m(function(){t.removeChild(l)},50);for(var d in y[c])y[c].hasOwnProperty(d)&&y[c][d].onload()}}var j=j||B.errorTimeout,l=b.createElement(a),o=0,r=0,u={t:d,s:c,e:f,a:i,x:j};1===y[c]&&(r=1,y[c]=[]),"object"==a?l.data=c:(l.src=c,l.type=a),l.width=l.height="0",l.onerror=l.onload=l.onreadystatechange=function(){k.call(this,r)},p.splice(e,0,u),"img"!=a&&(r||2===y[c]?(t.insertBefore(l,s?null:n),m(k,j)):y[c].push(l))}function j(a,b,c,d,f){return q=0,b=b||"j",e(a)?i("c"==b?v:u,a,b,this.i++,c,d,f):(p.splice(this.i++,0,a),1==p.length&&h()),this}function k(){var a=B;return a.loader={load:j,i:0},a}var l=b.documentElement,m=a.setTimeout,n=b.getElementsByTagName("script")[0],o={}.toString,p=[],q=0,r="MozAppearance"in l.style,s=r&&!!b.createRange().compareNode,t=s?l:n.parentNode,l=a.opera&&"[object Opera]"==o.call(a.opera),l=!!b.attachEvent&&!l,u=r?"object":l?"script":"img",v=l?"script":u,w=Array.isArray||function(a){return"[object Array]"==o.call(a)},x=[],y={},z={timeout:function(a,b){return b.length&&(a.timeout=b[0]),a}},A,B;B=function(a){function b(a){var a=a.split("!"),b=x.length,c=a.pop(),d=a.length,c={url:c,origUrl:c,prefixes:a},e,f,g;for(f=0;f<d;f++)g=a[f].split("="),(e=z[g.shift()])&&(c=e(c,g));for(f=0;f<b;f++)c=x[f](c);return c}function g(a,e,f,g,h){var i=b(a),j=i.autoCallback;i.url.split(".").pop().split("?").shift(),i.bypass||(e&&(e=d(e)?e:e[a]||e[g]||e[a.split("/").pop().split("?")[0]]),i.instead?i.instead(a,e,f,g,h):(y[i.url]?i.noexec=!0:y[i.url]=1,f.load(i.url,i.forceCSS||!i.forceJS&&"css"==i.url.split(".").pop().split("?").shift()?"c":c,i.noexec,i.attrs,i.timeout),(d(e)||d(j))&&f.load(function(){k(),e&&e(i.origUrl,h,g),j&&j(i.origUrl,h,g),y[i.url]=2})))}function h(a,b){function c(a,c){if(a){if(e(a))c||(j=function(){var a=[].slice.call(arguments);k.apply(this,a),l()}),g(a,j,b,0,h);else if(Object(a)===a)for(n in m=function(){var b=0,c;for(c in a)a.hasOwnProperty(c)&&b++;return b}(),a)a.hasOwnProperty(n)&&(!c&&!--m&&(d(j)?j=function(){var a=[].slice.call(arguments);k.apply(this,a),l()}:j[n]=function(a){return function(){var b=[].slice.call(arguments);a&&a.apply(this,b),l()}}(k[n])),g(a[n],j,b,n,h))}else!c&&l()}var h=!!a.test,i=a.load||a.both,j=a.callback||f,k=j,l=a.complete||f,m,n;c(h?a.yep:a.nope,!!i),i&&c(i)}var i,j,l=this.yepnope.loader;if(e(a))g(a,0,l,0);else if(w(a))for(i=0;i<a.length;i++)j=a[i],e(j)?g(j,0,l,0):w(j)?B(j):Object(j)===j&&h(j,l);else Object(a)===a&&h(a,l)},B.addPrefix=function(a,b){z[a]=b},B.addFilter=function(a){x.push(a)},B.errorTimeout=1e4,null==b.readyState&&b.addEventListener&&(b.readyState="loading",b.addEventListener("DOMContentLoaded",A=function(){b.removeEventListener("DOMContentLoaded",A,0),b.readyState="complete"},0)),a.yepnope=k(),a.yepnope.executeStack=h,a.yepnope.injectJs=function(a,c,d,e,i,j){var k=b.createElement("script"),l,o,e=e||B.errorTimeout;k.src=a;for(o in d)k.setAttribute(o,d[o]);c=j?h:c||f,k.onreadystatechange=k.onload=function(){!l&&g(k.readyState)&&(l=1,c(),k.onload=k.onreadystatechange=null)},m(function(){l||(l=1,c(1))},e),i?k.onload():n.parentNode.insertBefore(k,n)},a.yepnope.injectCss=function(a,c,d,e,g,i){var e=b.createElement("link"),j,c=i?h:c||f;e.href=a,e.rel="stylesheet",e.type="text/css";for(j in d)e.setAttribute(j,d[j]);g||(n.parentNode.insertBefore(e,n),m(c,0))}}(this,document),Modernizr.load=function(){yepnope.apply(window,[].slice.call(arguments,0))}; \ No newline at end of file -- 2.20.1