From e71c3473557308f4874b942aedad55aa0562e5b9 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Mon, 10 Jan 2022 08:01:20 -0300
Subject: [PATCH] Bug 29562: (follow-up) Fix API controller

This patch fixes tests failures due to bad checks in the controller.
The tests deserve to be rewritten.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 C4/Reserves.pm        | 2 +-
 Koha/REST/V1/Holds.pm | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index 3a49f7cc1b9..0b79951cedb 100644
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -388,7 +388,7 @@ sub CanItemBeReserved {
 
     # we retrieve borrowers and items informations #
     # item->{itype} will come for biblioitems if necessery
-    my $biblio     = $item->biblio;
+    my $biblio   = $item->biblio;
     my $borrower = $patron->unblessed;
 
     # If an item is damaged and we don't allow holds on damaged items, we can stop right here
diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm
index d4f6dbcf3e3..3df81eb6ad1 100644
--- a/Koha/REST/V1/Holds.pm
+++ b/Koha/REST/V1/Holds.pm
@@ -165,7 +165,7 @@ sub add {
         ) unless $valid_pickup_location || $can_override;
 
         my $can_place_hold
-            = $item_id
+            = $item
             ? C4::Reserves::CanItemBeReserved( $patron, $item )
             : C4::Reserves::CanBookBeReserved( $patron_id, $biblio_id );
 
@@ -192,7 +192,7 @@ sub add {
             {
                 branchcode       => $pickup_library_id,
                 borrowernumber   => $patron_id,
-                biblionumber     => $biblio_id,
+                biblionumber     => $biblio->id,
                 priority         => $priority,
                 reservation_date => $hold_date,
                 expiration_date  => $expiration_date,
-- 
2.25.1