From 1d34c571d65ddda6abc15bd047578e817414422e Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Fri, 28 Jan 2022 15:56:52 -1000 Subject: [PATCH] Bug 29878: (follow-up) Fix opac-topissues.pl This page is using the preference AdvancedSearchTypes with wrong split character Test plan : 1) Enable preference OpacTopissue 2) In OPAC click on 'Most popular' 3) Check you see filters on ccode and/or itemtype when they are in AdvancedSearchTypes --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc | 2 +- opac/opac-topissues.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc index 11e0b4cf6d..da9e1b2441 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc @@ -25,7 +25,7 @@ [% END %] - [% AdvancedSearchTypes = Koha.Preference('AdvancedSearchTypes').split('\|') %] + [% AdvancedSearchTypes = Koha.Preference('AdvancedSearchTypes').split(',') %] [% IF AdvancedSearchTypes.grep('^itemtypes$').size %]
  • diff --git a/opac/opac-topissues.pl b/opac/opac-topissues.pl index f185702e32..f81f646a1e 100755 --- a/opac/opac-topissues.pl +++ b/opac/opac-topissues.pl @@ -65,7 +65,7 @@ if (!$do_it && C4::Context->userenv && C4::Context->userenv->{'branch'} ) { my $itemtype = $input->param('itemtype') || ''; my $timeLimit = $input->param('timeLimit') || 3; my $advanced_search_types = C4::Context->preference('AdvancedSearchTypes'); -my @advanced_search_types = split /\|/, $advanced_search_types; +my @advanced_search_types = split /,/, $advanced_search_types; my $params = { count => $limit, -- 2.34.0