From 9a2cd3efb9d1c5e9edc32fa2603b4ad6cfc4d3bc Mon Sep 17 00:00:00 2001 From: Liz Rea Date: Thu, 6 May 2021 13:33:21 -0500 Subject: [PATCH] Bug 24991: make koha-sip --restart start sip if it is not already running. To test: - make sure SIP is enabled sudo koha-sip --enable inst - make sure SIP is running sudo koha-sip --start inst sudo koha-sip --status inst - restart SIP, make sure it does this normally sudo koha-sip --restart inst - stop SIP, make sure it does this normally sudo koha-sip --stop inst - make sure SIP is not running (wild scenario: oomkiller or similar has killed this or some other thing has happened) sudo koha-sip --status inst - restart sip, make sure it starts SIP instead of silently failing sudo koha-sip --restart inst - check SIP is now running, or that there is an error message if it can't start sudo koha-sip --status inst Signed-off-by: Owen Leonard JD Amended patch: tidy the whole block --- debian/scripts/koha-sip | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/debian/scripts/koha-sip b/debian/scripts/koha-sip index 402e9fa2e3e..b3a1cd1dde5 100755 --- a/debian/scripts/koha-sip +++ b/debian/scripts/koha-sip @@ -166,11 +166,19 @@ restart_sip() done echo $noLF `start_sip ${name}` else + echo $noLF `start_sip ${name}` if [ "$verbose" != "no" ]; then - log_daemon_msg "Warning: SIP server not running for ${name}" + log_daemon_msg "Warning: SIP server not running for ${name}... trying to start" log_end_msg 0 - else + fi + if is_sip_running ${name}; then return 0 + else + if [ "$verbose" != "no" ]; then + log_daemon_msg "Warning: SIP server not started, check your config" + log_end_msg 0 + fi + return 1 fi fi } -- 2.25.1