From e063be5a04a0ce9c2977dbdf1efe5767b7c886c8 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Tue, 18 May 2021 08:31:00 +0100 Subject: [PATCH] Bug 28294: Remove use of updateWrongTransfer This patch removes the last remaining use of updateWrongTransfer. Test plan 1/ git grep updateWrongTransfer to confirm there are no more uses of the method. 2/ Confirm an incorrect transfer still behaves as expected at circulation returns. --- circ/returns.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/circ/returns.pl b/circ/returns.pl index 6a9ec17617..648f7d278d 100755 --- a/circ/returns.pl +++ b/circ/returns.pl @@ -35,7 +35,7 @@ use CGI qw ( -utf8 ); use DateTime; use C4::Auth qw( get_template_and_user get_session haspermission ); -use C4::Circulation qw( barcodedecode GetBranchItemRule AddReturn updateWrongTransfer LostItem ); +use C4::Circulation qw( barcodedecode GetBranchItemRule AddReturn LostItem ); use C4::Context; use C4::Items qw( ModItemTransfer ); use C4::Members::Messaging; @@ -400,7 +400,8 @@ if ( $messages->{'WrongTransfer'} and not $messages->{'WasTransfered'}) { ); # Update the transfer to reflect the new item holdingbranch - my $new_transfer = updateWrongTransfer($messages->{'WrongTransferItem'},$messages->{'WrongTransfer'}, $userenv_branch); + my $transfer = Koha::Items->find($messages->{'WrongTransferItem'})->get_transfer; + my $new_transfer = $transfer->remedy(); $template->param( NewTransfer => $new_transfer->id ); -- 2.20.1