From f1336b5ad22503f67e762f99c65bd778aaae9c09 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 27 Jan 2022 11:50:28 +0000 Subject: [PATCH] Bug 29952: Replace obsolete DataTable column filter function The "Filter paid transactions" link on the Accounting -> Transactions page is broken because it uses an obsolete DataTables function for filtering. This patch updates it to use the current syntax, available in DataTables since version 1.10. To test, apply the patch and locate a patron in the staff interface who has multiple fines, some paid. - View the patron's "Accounting" page and click the "Transactions" tab. - Click the "Filter paid transactions" link. The table should be filtered so that only transactions with an outstanding amount > zero are shown. - The filter link should change to read "Show all transactions." - Clicking "Show all transactions" should clear the filter. - Test with one or more columns hidden using the "Columns" control. Filtering should still work correctly with columns hidden. Signed-off-by: David Nind Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt index 4b0452b2dba..2fd9240414b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt @@ -349,7 +349,7 @@ var filteredValue = '^((?!0.00).*)$'; //Filter not matching 0.00 http://stackoverflow.com/a/406408 $(this).html(' '+txtInactivefilter); } - table_account_fines.fnFilter(filteredValue, 10, true, false); + table_account_fines.DataTable().columns( 13 ).search( filteredValue, true, false ).draw(); $(this).toggleClass('filtered'); }); -- 2.25.1