From 081a877353bbdc8317400d7713c537bd6f50d917 Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Mon, 15 Mar 2021 16:02:34 +0000
Subject: [PATCH] Bug 24295: Remove GetTransfers from opac-detail.pl

This patch replaces the call to GetTransfers in opac-detail with the
get_transfer method available from the Koha::Item object

Test plan
1/ Trigger the transfer of the item
2/ Check the opac-detail page for the display of the current transfer
   status
3/ Apply patch
4/ Repeat step 2
---
 opac/opac-detail.pl | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl
index 1c705db734..abf2910214 100755
--- a/opac/opac-detail.pl
+++ b/opac/opac-detail.pl
@@ -47,7 +47,6 @@ use C4::Biblio qw(
     GetMarcUrls
 );
 use C4::Items qw( GetHiddenItemnumbers GetItemsInfo );
-use C4::Circulation qw( GetTransfers );
 use C4::Tags qw( get_tags );
 use C4::XISBN qw( get_xisbns );
 use C4::External::Amazon qw( get_amazon_tld );
@@ -71,6 +70,7 @@ use C4::HTML5Media;
 use C4::CourseReserves qw( GetItemCourseReservesInfo );
 
 use Koha::Biblios;
+use Koha::DateUtils qw( output_pref );
 use Koha::RecordProcessor;
 use Koha::AuthorisedValues;
 use Koha::CirculationRules;
@@ -732,13 +732,14 @@ if ( not $viewallitems and @items > $max_items_to_display ) {
      my $reserve_status = C4::Reserves::GetReserveStatus($itm->{itemnumber});
       if( $reserve_status eq "Waiting"){ $itm->{'waiting'} = 1; }
       if( $reserve_status eq "Reserved"){ $itm->{'onhold'} = 1; }
-    
-     my ( $transfertwhen, $transfertfrom, $transfertto ) = GetTransfers($itm->{itemnumber});
-     if ( defined( $transfertwhen ) && $transfertwhen ne '' ) {
-        $itm->{transfertwhen} = $transfertwhen;
-        $itm->{transfertfrom} = $transfertfrom;
-        $itm->{transfertto}   = $transfertto;
-     }
+
+
+    my $transfer = $item->get_transfer;
+    if ( $transfer && $transfer->in_transit ) {
+        $itm->{transfertwhen} = output_pref({ dt => dt_from_string($transfer->datesent) });
+        $itm->{transfertfrom} = $transfer->frombranch;
+        $itm->{transfertto} = $transfer->tobranch;
+    }
     
     if ( C4::Context->preference('OPACAcquisitionDetails') ) {
         $itm->{on_order} = 1
-- 
2.20.1