From 2da897e343d2cee7be43e28a635d4b943c778adc Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Mon, 15 Mar 2021 16:24:03 +0000 Subject: [PATCH] Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. --- svc/holds | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/svc/holds b/svc/holds index 77c260ff27..682c2e5aea 100755 --- a/svc/holds +++ b/svc/holds @@ -24,7 +24,6 @@ use JSON qw(to_json); use C4::Auth qw(check_cookie_auth); use C4::Charset; -use C4::Circulation qw(GetTransfers); use C4::Context; use Koha::DateUtils qw( dt_from_string output_pref ); @@ -138,13 +137,12 @@ while ( my $h = $holds_rs->next() ) { $hold->{enumchron} = $item->enumchron(); $hold->{itemcallnumber} = $item->itemcallnumber() || q{}; - my ( $transferred_when, $transferred_from, $transferred_to ) = - GetTransfers( $item->itemnumber() ); - if ($transferred_when) { + my $transfer = $item->get_transfer; + if ( $transfer && $transfer->in_transit ) { $hold->{color} = 'transferred'; $hold->{transferred} = 1; - $hold->{date_sent} = output_pref( dt_from_string($transferred_when) ); - $hold->{from_branch} = Koha::Libraries->find($transferred_from)->branchname; + $hold->{date_sent} = output_pref({ dt => dt_from_string($transfer->datesent) }); + $hold->{from_branch} = Koha::Libraries->find($transfer->frombranch)->branchname; } elsif ( $item->holding_branch() && $item->holding_branch()->branchcode() ne $h->branch()->branchcode() ) -- 2.20.1