Attachment 130466 Details for Bug 29495 – [21.05.x] Bug 29495: (follow-up) Use 'item' relationship

[patch] [21.05.x] Bug 29495: (follow-up) Use 'item' relationship

2105x-Bug-29495-follow-up-Use-item-relationship.patch (text/plain), 1.24 KB, created by Tomás Cohen Arazi (tcohen) on 2022-02-10 18:57:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2022-02-10 18:57:43 UTC

Size: 1.24 KB

patch

obsolete

>From 622fd014c765f426c3ea0121b4de49ed82062b89 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 18 Nov 2021 15:47:02 +0000
>Subject: [PATCH] [21.05.x] Bug 29495: (follow-up) Use 'item' relationship
>
>This patch adds the missing 'item' relationship in
>Checkouts::ReturnClaim and then uses it from the resolve method.
>
>This improve the reliability of the resolution code so it works when the
>item has already been checked in (without having to check
>Old::Checkouts).
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Schema/Result/ReturnClaim.pm | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
>diff --git a/Koha/Schema/Result/ReturnClaim.pm b/Koha/Schema/Result/ReturnClaim.pm
>index 4e2c56c40b..9e67c7f0e7 100644
>--- a/Koha/Schema/Result/ReturnClaim.pm
>+++ b/Koha/Schema/Result/ReturnClaim.pm
>@@ -316,6 +316,21 @@ __PACKAGE__->belongs_to(
>     },
> );
> 
>+=head2 item
>+
>+Type: belongs_to
>+
>+Related object: L<Koha::Schema::Result::Item>
>+
>+=cut
>+
>+__PACKAGE__->belongs_to(
>+  "item",
>+  "Koha::Schema::Result::Item",
>+  { itemnumber => "itemnumber" },
>+  { is_deferrable => 1, on_delete => "CASCADE", on_update => "CASCADE" },
>+);
>+
> sub koha_objects_class {
>     'Koha::Checkouts::ReturnClaims';
> }
>-- 
>2.35.1

Actions: View | Diff | Splinter Review

Attachments on bug 29495: 127711 | 127712 | 127713 | 127714 | 127765 | 127766 | 127767 | 127768 | 127769 | 127809 | 127810 | 127811 | 127812 | 127813 | 127937 | 127938 | 127939 | 127940 | 127941 | 127942 | 127943 | 127944 | 129105 | 129106 | 129107 | 129109 | 129110 | 129111 | 129112 | 129113 | 129547 | 129575 | 129582 | 130460 | 130461 | 130462 | 130463 | 130464 | 130465 | 130466 | 130467 | 130752 | 130753 | 130754 | 130755 | 130756 | 130757 | 130758