Bugzilla – Attachment 130486 Details for
Bug 26704
Koha::Item store triggers should utilise Koha::Object::Messages for message passing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26704: (follow-up) Rebase for bug 29785
Bug-26704-follow-up-Rebase-for-bug-29785.patch (text/plain), 1.52 KB, created by
Martin Renvoize
on 2022-02-11 10:35:17 UTC
(
hide
)
Description:
Bug 26704: (follow-up) Rebase for bug 29785
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2022-02-11 10:35:17 UTC
Size:
1.52 KB
patch
obsolete
>From e6409b5651247f7e3c95f862d250ec869a358543 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 11 Feb 2022 10:32:04 +0000 >Subject: [PATCH] Bug 26704: (follow-up) Rebase for bug 29785 > >Update newly introduced calls from '->messages' to '->object_messages' > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Circulation.pm | 2 +- > t/db_dependent/Koha/Item.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index aded8a5b3b..17cab0c74b 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2128,7 +2128,7 @@ sub AddReturn { > if ($item_was_lost) { > $messages->{'WasLost'} = 1; > unless ( C4::Context->preference("BlockReturnOfLostItems") ) { >- my @object_messages = @{ $updated_item->messages }; >+ my @object_messages = @{ $updated_item->object_messages }; > for my $message (@object_messages) { > $messages->{'LostItemFeeRefunded'} = 1 > if $message->message eq 'lost_refunded'; >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index ac47d8fd48..0470a98c46 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -1199,7 +1199,7 @@ subtest 'store() tests' => sub { > # simulate it was found > $item->set( { itemlost => 0 } )->store; > >- my $messages = $item->messages; >+ my $messages = $item->object_messages; > > my $message_1 = $messages->[0]; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26704
:
118548
|
122004
|
128070
|
128084
|
128085
|
130027
|
130028
|
130484
|
130485
| 130486 |
130657
|
130658