From a4a3835fd1fac7570ad0f5052c9dd5212ff8cf57 Mon Sep 17 00:00:00 2001
From: Lari Taskula <lari.taskula@hypernova.fi>
Date: Fri, 11 Feb 2022 12:53:55 +0000
Subject: [PATCH] Bug 30081: Add item type column to holds table

Add new column item type to holds table in patron's details and check
out views. Some libraries will find this information useful for
distinguishing inter library holds from normal holds.

To test:
1. Apply patch
2. Place a hold and confirm it
3. Go to cgi-bin/koha/circ/circulation.pl?borrowernumber=1 with
   borrowernumber being the id of your patron
4. Click "1 Hold(s)" tab
5. Observe new column "Item type"
6. Confirm the item type is correct
7. Go to moremember.pl?borrowernumber=1 with
   borrowernumber being the id of your patron
8. Repeat steps 4-6
---
 .../intranet-tmpl/prog/en/modules/circ/circulation.tt    | 1 +
 .../intranet-tmpl/prog/en/modules/members/moremember.tt  | 1 +
 koha-tmpl/intranet-tmpl/prog/js/holds.js                 | 9 +++++++++
 3 files changed, 11 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
index 5ec6bd391a..7fcc1e20b1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
@@ -840,6 +840,7 @@
                                             <th>Hold date</th>
                                             <th>Title</th>
                                             <th>Call number</th>
+                                            <th>Item type</th>
                                             <th>Barcode</th>
                                             <th>Pickup at</th>
                                             <th>Expiration</th>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
index 81602072d0..deaec4c251 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ -776,6 +776,7 @@
                                                     <th>Hold date</th>
                                                     <th>Title</th>
                                                     <th>Call number</th>
+                                                    <th>Item type</th>
                                                     <th>Barcode</th>
                                                     <th>Pickup at</th>
                                                     <th>Expiration</th>
diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js
index 9f17863f1b..3136796cc8 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js
@@ -172,6 +172,15 @@ $(document).ready(function() {
                             return oObj.itemcallnumber && oObj.itemcallnumber.escapeHtml() || "";
                         }
                     },
+                    {
+                        "mDataProp": function( oObj ) {
+                            var data = "";
+                            if ( oObj.itemtype ) {
+                                data += oObj.itemtype;
+                            }
+                            return data;
+                        }
+                    },
                     {
                         "mDataProp": function( oObj ) {
                             var data = "";
-- 
2.25.1