Attachment 130732 Details for Bug 29660 – Bug 29660: Unused code in placerequest.pl

[patch] Bug 29660: Unused code in placerequest.pl

Bug-29660-Unused-code-in-placerequestpl.patch (text/plain), 2.43 KB, created by Martin Renvoize (ashimema) on 2022-02-17 13:07:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2022-02-17 13:07:14 UTC

Size: 2.43 KB

patch

obsolete

>From 6d672adaaef17af4967f286c152dcd395a7282e5 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 8 Dec 2021 15:32:14 +0100
>Subject: [PATCH] Bug 29660: Unused code in placerequest.pl
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/reserve/request.tt              |  1 -
> reserve/placerequest.pl                             | 13 -------------
> 2 files changed, 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index 90aaa8ef53..8df40c0974 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -540,7 +540,6 @@
>                                     [% ELSE %]
>                                         <input type="checkbox" id="requestany" name="request" checked="checked" value="Any" />
>                                     [% END %]
>-                                    <input type="hidden" name="biblioitem" value="[% biblioitemnumber | html %]" />
>                                     <input type="hidden" name="alreadyreserved" value="[% alreadyreserved | html %]" />
>                                 </li>
> 
>diff --git a/reserve/placerequest.pl b/reserve/placerequest.pl
>index 9f6d82dc4f..77d1c122f6 100755
>--- a/reserve/placerequest.pl
>+++ b/reserve/placerequest.pl
>@@ -34,7 +34,6 @@ my $input = CGI->new();
> 
> checkauth($input, 0, { reserveforothers => 'place_holds' }, 'intranet');
> 
>-my @bibitems       = $input->multi_param('biblioitem');
> my @reqbib         = $input->multi_param('reqbib');
> my $biblionumber   = $input->param('biblionumber');
> my $borrowernumber = $input->param('borrowernumber');
>@@ -72,18 +71,6 @@ my $found;
> if ( $type eq 'str8' && $patron ) {
> 
>     foreach my $biblionumber ( keys %bibinfos ) {
>-        my $count = @bibitems;
>-        @bibitems = sort @bibitems;
>-        my $i2 = 1;
>-        my @realbi;
>-        $realbi[0] = $bibitems[0];
>-        for ( my $i = 1 ; $i < $count ; $i++ ) {
>-            my $i3 = $i2 - 1;
>-            if ( $realbi[$i3] ne $bibitems[$i] ) {
>-                $realbi[$i2] = $bibitems[$i];
>-                $i2++;
>-            }
>-        }
> 
>         my $can_override = C4::Context->preference('AllowHoldPolicyOverride');
>         if ( defined $checkitem && $checkitem ne '' ) {
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 29660: 128366 | 128367 | 128368 | 129934 | 129935 | 129936 | 130352 | 130353 | 130354 | 130447 | 130731 | 130732 | 130733 | 130734