From ac99985b1a3abe52ebe52c473fedea6d2b6a9fa8 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 15 Feb 2022 16:25:59 +0100 Subject: [PATCH] Bug 30108: Allow making hold dates required Content-Type: text/plain; charset=utf-8 Side note: Template still referred to class holddateto while not being used any longer. Replaced this occurrence by futuredate. Test plan: [1] Disable OPACAllowHoldDateInFuture. [2] Set pref OPACMandatoryHoldDates to "end date". [3] Verify that the end date is mandatory on opac-reserve. [4] Set pref OPACMandatoryHoldDates to "start date". [5] Verify that no dates are required. [6] Enable OPACAllowHoldDateInFuture. [7] Verify that start dates are required. [8] Set pref OPACMandatoryHoldDates to "no dates". [9] Verify that no dates are required again. Bonus: Check that more options box is opened when a date still is required. In case of item level being forced, verify that more options is opened regardless of pref setting. Signed-off-by: Marcel de Rooy --- .../bootstrap/en/modules/opac-reserve.tt | 28 +++++++++++++++++-- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt index 2d84cdffb4..5a28eec95d 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ -281,7 +281,7 @@ [% IF ( reserve_in_future ) %]
  • - + [% INCLUDE 'date-format.inc' %]
  • [% END %] @@ -474,6 +474,7 @@ [% INCLUDE 'calendar.inc' %]